Page MenuHomePhabricator
Create Task
Maniphest T88296

WikiGrokDialogs not using View##event
Closed, ResolvedPublic
Actions

Description

See EditorOverlayBase as an example of how this works.
There should be no on events binded in postRender

Details

SubjectRepoBranchLines +/-
Use view eventsmediawiki/extensions/WikiGrokmaster+96 -67
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Feb 2 2015, 5:34 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2015, 5:34 PM
Jdlrobson renamed this task from ErrorReportOverlay not using View##event to ErrorReportOverlay, Infobox, WikiGrokDialogs not using View##event.Feb 2 2015, 5:34 PM
Jdlrobson set Security to None.
• KLans_WMF moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Feb 2 2015, 6:11 PM
Jdlrobson renamed this task from ErrorReportOverlay, Infobox, WikiGrokDialogs not using View##event to WikiGrokDialogs not using View##event.Feb 4 2015, 3:38 PM
Jdlrobson updated the task description. (Show Details)
• bmansurov added a project: WikiGrok.Feb 23 2015, 9:19 PM
Florian subscribed.Feb 23 2015, 9:19 PM
gerritbot subscribed.Mar 10 2015, 9:59 PM

Change 195772 had a related patch set uploaded (by Bmansurov):
Use view events

https://gerrit.wikimedia.org/r/195772

gerritbot added a project: Patch-For-Review.Mar 10 2015, 9:59 PM
• bmansurov moved this task from Triaged but Future to Needs Prioritization on the Web-Team-Backlog board.Mar 10 2015, 9:59 PM
phuedx closed this task as Resolved.Mar 13 2015, 1:25 PM
phuedx claimed this task.
phuedx removed a project: Patch-For-Review.
gerritbot added a comment.Mar 13 2015, 1:26 PM

Change 195772 merged by jenkins-bot:
Use view events

https://gerrit.wikimedia.org/r/195772

Diffusion mentioned this in rMEXT1c8dc0fbe90d: Updated mediawiki/extensions Project: mediawiki/extensions/WikiGrok….Mar 13 2015, 1:27 PM
• bmansurov mentioned this in rEWGR70162e53e788: Use view events.Mar 13 2015, 1:27 PM
• Phabricator_maintenance moved this task from Needs Prioritization to 2014-15 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:25 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL