Page MenuHomePhabricator

Add VisualEditor to Jenkins dependencies for WikiHiero
Closed, DuplicatePublic

Description

To fix https://integration.wikimedia.org/ci/job/mwext-wikihiero-testextension-zend/1/console

There was 1 failure:

1) ResourcesTest::testMissingDependencies
The module 'ext.visualEditor.mwcore' required by 'ext.wikihiero.visualEditor' must exist
Failed asserting that an array contains 'ext.visualEditor.mwcore'.

Event Timeline

MaxSem raised the priority of this task from to Needs Triage.
MaxSem updated the task description. (Show Details)
MaxSem added a project: Jenkins.
MaxSem subscribed.
Krinkle renamed this task from Add VisualEditor to WikiHiero CI dependencies to Add VisualEditor to Jenkins dependencies for WikiHiero.Feb 2 2015, 9:39 PM

Should be added to integration/config.git in jjb/mediawiki-extensions.yaml . An example for FlaggedRevs depending on Scribunto is https://git.wikimedia.org/blob/integration%2Fconfig.git/359a5646471cd66d006f96b3e4e10e2fc9e40d53/jjb%2Fmediawiki-extensions.yaml#L568

Though, I don't think Wikihiero should depend on VisualEditor. The resource should probably be added conditionally and a few tasks have been opened in that sense for other repos ( T88233 T88231 T88230 T88229 tracked by T88227: Multiple extensions: VisualEditor JavaScript should only be added if VisualEditor is installed).