Page MenuHomePhabricator

Please delete the getTemplateArgs() method from Parser.php if it is not called
Closed, ResolvedPublic


Author: nickpj


The getTemplateArgs() function in Parser.php does not appear to be called:

root@bling:/var/www/hosts/mediawiki/wiki# grep -inr getTemplateArgs *
includes/.svn/text-base/Parser.php.svn-base:2602: function
getTemplateArgs( $argsString ) {
includes/Parser.php:2602: function getTemplateArgs( $argsString ) {


Can we maybe kill it?

Version: 1.8.x
Severity: trivial



Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 9:17 PM
bzimport set Reference to bz6835.
bzimport added a subscriber: Unknown Object (MLST).

Is this possibly to allow extensions to gain access to template parameters so they can decode {{{parameter}}}?

I recall this being an issue a little while back...

nickpj wrote:

Removed in r16925 (could not see any external extensions using this, and if it's
removed now it gives the maximum window of opportunity for it to be added back
in case someone somewhere turns out to be using it). Marking as resolved.