Page MenuHomePhabricator

Page with collapsible sections contains divs with non-unique id values
Closed, ResolvedPublic

Description

Seen as of 2 Feb

On the page at http://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_section_test_page

Collapse the first section

Inspect the page, search for divs with id "collapsible-block-0". Several exist.

id values must be unique per HTML page per W3C standards: http://www.w3schools.com/tags/att_global_id.asp

This causes a browser test to incur a false failure: https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/526/testReport/junit/(root)/Toggling%20sections/Section_open_by_default_on_tablet/{F36546}

Details

Related Gerrit Patches:
mediawiki/extensions/MobileFrontend : masterMake section IDs unique

Event Timeline

Cmcmahon raised the priority of this task from to High.
Cmcmahon updated the task description. (Show Details)
Cmcmahon added a subscriber: Cmcmahon.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 3 2015, 8:18 PM
Cmcmahon updated the task description. (Show Details)Feb 3 2015, 8:18 PM
Cmcmahon added a project: Browser-test-bug.
Cmcmahon set Security to None.
bmansurov claimed this task.Feb 4 2015, 9:03 PM
Jdlrobson reopened this task as Open.Feb 4 2015, 9:06 PM

Oh wait, the validator won't run on stuff added via JS. Yes you are right it seems there are 2 versions of #collapsible-block-0 - table of contents and first heading. Yeh that's bad.

gerritbot added a subscriber: gerritbot.

Change 188672 had a related patch set uploaded (by Bmansurov):
Make section IDs unique

https://gerrit.wikimedia.org/r/188672

Patch-For-Review

Florian closed this task as Resolved.Feb 4 2015, 10:46 PM
Florian added a subscriber: Florian.

Change 188672 merged by jenkins-bot:
Make section IDs unique

https://gerrit.wikimedia.org/r/188672