Page MenuHomePhabricator

Make buttonWidget (normal, progressive, constructive, destructive) borderless (quiet by default)
Closed, DeclinedPublic

Description

Now:

Screenshot_2015-02-03_11.29.53.png (353×202 px, 24 KB)

Should be: M37

Event Timeline

violetto assigned this task to Prtksxna.
violetto raised the priority of this task from to Needs Triage.
violetto updated the task description. (Show Details)
violetto subscribed.
Prtksxna set Security to None.

Why do we want normal buttons to be quiet? Where are these being used right now, should they really frameless? If so what is the use of frameless buttons?

violetto changed the task status from Open to Stalled.Mar 6 2015, 8:10 AM

@Prtksxna, we just realized that these normal buttons are only used in VE in a few screens. These type of normal buttons (colored outlined and colored text on normal state) does not exist in mw.UI.

This remain as an issue. Hence, I'm marking this as stalled until we find a solution.

@violetto Feel free to re-assign it once you've come to a resolution.

@Nirzar & @violetto we decided to make the default state quiet, you have to throw on a primary label to get a button bound?

Jaredzimmerman-WMF renamed this task from Make buttonWidget (normal, progressive, constructive, destructive) borderless to Make buttonWidget (normal, progressive, constructive, destructive) borderless (quiet by default).Mar 24 2015, 1:40 AM

For the record, there are a few blocking tasks by @Nirzar and @KHammerstein to get this resolved. cc @Jaredzimmerman-WMF

If you look at https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/#widgets-mediawiki-vector-ltr , it shows 1) framed primary buttons, then 2) framed not-primary neutral/constructive/progressive/destructive buttons, then 3) no-framed not-primary buttons. The LSG only shows Primary (1) and Quiet (3), but its Quiet text describes (2), hence I filed T116882: LSG Quiet button description doesn't match the buttons next to it, while OOUI demo has additional framed buttons..

It sounds like this bug is deprecating colored (2). "Don't use colors (constructive/progressive/destructive) with framed unless it's the primary button". Unless you're asking for the OOjs UI toolkit to error on this, it's just a guideline.

The toolkit's terminology need not match the styleguide,though it's confusing.

Closing this as declined as there's currently no good reason to do this from a user experience point of view.
Feel free to reopen this task whenever new arguments are presented.