ImageOverlay should use View##events
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Feb 4 2015, 3:36 PM

Description

See EditorOverlayBase as an example of how this works.
There should be no on events binded in postRender

	Subject	Repo	Branch	Lines +/-
	Hygiene: ImageOverlay should use View##events	mediawiki/extensions/MobileFrontend	master	+12 -4

Mentioned In: rMEXT0b97615b3a37: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
rEMFR579c2e7620d1: Hygiene: ImageOverlay should use View##events

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 4 2015, 3:36 PM

Change 188622 had a related patch set uploaded (by Jdlrobson):
Hygiene: ImageOverlay should use View##events

whoops.

Jdlrobson closed this task as Resolved.Mar 4 2015, 9:36 PM

Change 188622 merged by jenkins-bot:
Hygiene: ImageOverlay should use View##events