Current:
These appear to be the same as quiet buttons and anchors but with an icon accompanied with label. Spec here: M37
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Prtksxna | T88622 ButtonWidget (frameless…) to be styled like quiet buttons/normal anchors | |||
| Resolved | Catrope | T97816 Support icons changing color on hover in MediaWiki's use of OOUI |
Event Timeline
Comment Actions
Change 189947 had a related patch set uploaded (by Prtksxna):
MediaWiki Theme: Use darker color for frameless buttons
Comment Actions
Change 189947 merged by jenkins-bot:
MediaWiki Theme: Use darker color for frameless buttons
Comment Actions
I'm reopening this task because it isn't resolved yet. As far as I can tell, only the disabled button is resolved like described in https://gerrit.wikimedia.org/r/189947.
Comment Actions
Change 193790 had a related patch set uploaded (by Prtksxna):
Use the correct color for gray buttons
Comment Actions
Change 193793 had a related patch set uploaded (by Prtksxna):
Use only 2 variables each for each semantic color
Comment Actions
Change 193793 merged by jenkins-bot:
Use only two variables each for each semantic color
Comment Actions
In quiet buttons, icons need to be #555 all the time and change color according to their class (progressive, destructive…) on hover.
Is that right @violetto?
Comment Actions
@matmarex, is there a way in src/themes/mediawiki/MediaWikiTheme.js to change the icon of the element on hover? Will we have to do this with some crazy filters in the CSS?
Comment Actions
Change 196210 had a related patch set uploaded (by Prtksxna):
[wip] Quiet colors on icons for quiet buttons
Comment Actions
How do we want to change the icon on hover then? Changing ButtonElement.js for a MediaWiki theme requirement? Does Apex need this anywhere?
Comment Actions
Probably. It would need to add some class on hover (or a flag) and remove it on de-hover. It's a pity that this design requirement was not communicated earlier, we would have implemented the system to handle this use case without hacks.
Does Apex need this anywhere?
No. Apex does not have colored icons.
Comment Actions
@matmarex, prior to going down svg route vs. icon font, there was a list of requirements communicated here on etherpad and in an email thread with the subject line "Icons into SVGs"
@TrevorParscal should be familiar with the requirements, not sure if he's shared them with you.
Comment Actions
I am aware that requirements were communicated. This one, however, wasn't. (There is nothing even in M37 about the required behavior of icon colors.)
If I had known that the design will require the ability to choose the icon variant displayed with no help from JS or PHP logic, with CSS only, I would have made the system more sophisticated to allow it. I hadn't and I didn't, and therefore we will need to implement this in JS logic (or refactor the system).
It can be done, though it will be a bit less neat.
Comment Actions
Wondering how you guys are fulfilling the requirement for icon color change that was listed as part of the requirement list? If the said requirement was taken into consideration, I'm curious why would the application on this use case be a hack?
Comment Actions
Hey @matmarex, just wanted to get an idea of when we can start seeing icons change color on hover. It's been a while since we last talked about this, it's still a critical issue.
Comment Actions
We've been discussing this on T97816 with @Catrope. Sorry, I can't give you a date. I've been reassigned to Multimedia and I'm trying to split my time between that, maintaining OOjs UI, and tieing up my other projects. Please ask somebody who actually has the power to prioritize big changes :)