Page MenuHomePhabricator

ButtonGroupWidget use cases
Closed, ResolvedPublic1 Estimated Story Points

Description

A few questions for this:

A button group like this is typically used for showing different views of a page (e.g.: compact, detailed) or sub-sections (e.g.: List, modified) within a section (e.g.: Watchlist). These selections tend to have the same hierarchy, no negative, positive, primary, etc. With that in mind:

  1. I don't think we need colored labels here, but let me know if you have a use case.
  2. Will there be a need for a drop down within this button group?
  3. Do we need multiple selections at once for this control?

Screenshot_2015-02-04_16.36.47.png (170×241 px, 16 KB)

We do have this control designed for filtering that @Nirzar did that supports multi-selections.

Event Timeline

violetto raised the priority of this task from to Needs Triage.
violetto updated the task description. (Show Details)
violetto added subscribers: violetto, Nirzar.
violetto renamed this task from ButtonGroupWidget to ButtonGroupWidget use cases.Feb 5 2015, 12:47 AM
violetto set Security to None.

I don't think we need colored labels here, but let me know if you have a use case.

I remember talking to @TrevorParscal about this and he said that there is no use case for it. Quite a few examples on that page are only for the purpose of testing.

@Prtksxna I don't think this needs to support Intentions…

I assume this task was inspired by our demo page.

  1. I don't think we need colored labels here, but let me know if you have a use case.

Indeed, we probably don't. The widget supports it, but it is not intentional, it's just a feature of how we build the widgets out of smaller parts. Regular buttons support having progressive/constructive/destructive flags, therefore buttons within button groups also do. I'll remove this from the demo.

  1. Will there be a need for a drop down within this button group?

Probably not. The widget does support it, though (again, it's just because of how we build the widgets – if you can have any button there, then you can have a button with a popup associated). I'll remove this from the demo too, the dropdown was not functional anyway (it was just the arrow).

  1. Do we need multiple selections at once for this control?

Probably not. This was already removed from the demo since this bug was filed.

Change 204981 had a related patch set uploaded (by Bartosz Dziewoński):
demo: Simplify ButtonGroupWidget and ButtonSelectWidget examples

https://gerrit.wikimedia.org/r/204981

Change 204981 merged by jenkins-bot:
demo: Simplify ButtonGroupWidget and ButtonSelectWidget examples

https://gerrit.wikimedia.org/r/204981