Page MenuHomePhabricator

ConfirmEdit shouldn't have several entry points
Closed, DeclinedPublic

Description

It's weird to have an own entry point for every CAPTCHA module, you have to require confirmedit and the captcha module and set a config var, which makes the installation process crappy. All CAPTCHA modules should live in ConfirmEdits entry point and one config var should be used to choose the correct CAPTCHA module. This would make it easier to convert ConfirmEdit to use extension registration.

Event Timeline

Florian claimed this task.
Florian raised the priority of this task from to Medium.
Florian updated the task description. (Show Details)
Florian subscribed.

The original idea was that other extensions could register new captcha types, without having to live in ConfirmEdit; basically each captcha type is its own extension already, they just live in the same directory and all depend on the core ConfirmEdit.

This does seem to be confusing to people though :)

gerritbot subscribed.

Change 188876 had a related patch set uploaded (by Florianschmidtwelzow):
Reorganise how ConfirmEdit is setup

https://gerrit.wikimedia.org/r/188876

Patch-For-Review

The original idea was that other extensions could register new captcha types, without having to live in ConfirmEdit; basically each captcha type is its own extension already, they just live in the same directory and all depend on the core ConfirmEdit.

This does seem to be confusing to people though :)

Ah, ok, thanks to clarify this! :D I think, it would be good to have ConfirmEdit itself a bit cleaner and other extensiosn are still able to register own CAPTCHA types (unfortunately it isn't used widely :/), so i think we should work on it to make it less confusing :)

Jdforrester-WMF set Security to None.
Jdforrester-WMF subscribed.

Per discussion, we're not going to do this.

Change 188876 abandoned by Jforrester:
Reorganise how ConfirmEdit is setup

Reason:
Task declined.

https://gerrit.wikimedia.org/r/188876