Page MenuHomePhabricator

Use parentRevId field for section change merging instead of timestamps
Open, Needs TriagePublic

Description

This avoids races better. The field was already added for edit stashing.

Event Timeline

aaron created this task.Feb 5 2015, 8:09 PM
aaron raised the priority of this task from to Needs Triage.
aaron updated the task description. (Show Details)
aaron added a project: MediaWiki-Core-Team.
aaron moved this task to Backlog on the MediaWiki-Core-Team board.
aaron added subscribers: aaron, awight.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2015, 8:09 PM
awight added a comment.Feb 5 2015, 9:39 PM

woot! I've been doing a little work to prepare for this, I'll paste in my WIP patch and some suggestions for renaming internal variables to reduce confusion.

aaron updated the task description. (Show Details)Feb 5 2015, 9:45 PM
aaron set Security to None.
Schnark added a subscriber: Schnark.Feb 6 2015, 9:16 AM

Sounds similar to what I suggested in T34037#366435.

awight added a comment.Apr 9 2015, 8:08 AM

Possibly should be merged into T58849

@daniel, works for me, thanks for cleaning this up! The part I care most about is handled by other vars now, it seems:

editRevId and getBaseRevision() return the latest current revision as known to the client. This can be used to detect edit conflicts.