Description
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| phab: direct_comments_allowed for Domains tickets | operations/puppet | production | +1 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • chasemp | T88842 enable email for tickets in domains project? | |||
| Resolved | Aklapper | T87465 create a project for tasks related to WMF domain names |
Event Timeline
Change 189140 had a related patch set uploaded (by Dzahn):
phab: direct_comments_allowed for Domains tickets
there's a patch now trying to enable the direct_comments, please see above. i'm currently not sure why jenkins dislikes it
reason was that 'Domains' was capitalized. but it's still unclear why that was considered a syntax error by operations-puppet-pplint-HEAD.
anyways, project tag was renamed to 'domains' in phab. also added wikimedia.org to be able to test.
https://gerrit.wikimedia.org/r/#/c/190383/
@RobH wanna test?
That was intentional, because by default projects are capitalized in Phab (except for when there are good reasons, like package names).
anyways, project tag was renamed to 'domains' in phab.
So the next person renaming the project in Phab and not being aware of this conversation will break this again? Might be worth to add some notice to the project description why it needs to be lower case?
none of the other ops tags, operations, ops-eqiad, ops-codfw etc are capitalized. but maybe they all need to be renamed then. i dunno, but there is a good reason, it lets jenkins vote down my puppet change :p
Closing as inactive and AFAIK it looks like what was wanted is accomplished. @Dzahn, please reopen if I'm mistaken.
It should be resolved, it just wasn't technically tested. the difference to other queues where it works and has been tested is that it specifies domain names instead of just *. The real test would be if somebody from MarkMonitor would reply by mail into a ticket. But it's ok that it's closed as inactive for now.