Page MenuHomePhabricator
Create Task
Maniphest T89012

Flickr option tends to reappear despite not having flickr import rights
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

  • go to commons without flickr import rights
  • upload a file
  • remove it
  • flickr import button incorrectly appears, and actually provides the flickr UI
  • the user can be tempted to import from flickr, and will get blocked after providing a URL with the very cryptic "permissiondenied" error message

While you're at it, please also check whether the buttons behave correctly when going back to step 1 after fully uploading a file.

Details

SubjectRepoBranchLines +/-
Fix flickr import button visibilitymediawiki/extensions/UploadWizardmaster+92 -52
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Gilles created this task.Feb 9 2015, 6:14 PM
• Gilles assigned this task to MarkTraceur.
• Gilles raised the priority of this task from to High.
• Gilles updated the task description. (Show Details)
• Gilles added projects: Multimedia, UploadWizard.
• Gilles added subscribers: • Gilles, Aklapper.
• Gilles moved this task from Untriaged to Next up on the Multimedia board.Feb 11 2015, 1:05 PM
• Gilles claimed this task.Mar 12 2015, 12:04 PM
• Gilles added a project: Multimedia-Sprint-2015-03-11.
• Gilles added a subscriber: MarkTraceur.
• Gilles set Security to None.Mar 13 2015, 10:19 AM
• Gilles edited a custom field.
gerritbot subscribed.Mar 13 2015, 10:35 AM

Change 196557 had a related patch set uploaded (by Gilles):
Fix flickr import button visibility

https://gerrit.wikimedia.org/r/196557

gerritbot added a project: Patch-For-Review.Mar 13 2015, 10:35 AM
• Gilles moved this task from Backlog to Needs code review on the Multimedia-Sprint-2015-03-11 board.Mar 13 2015, 10:35 AM
Steinsplitter added a project: Commons.Mar 13 2015, 6:38 PM
Steinsplitter moved this task from Incoming to Uploading on the Commons board.Mar 13 2015, 6:40 PM
MarkTraceur moved this task from Needs code review to Ready for testing on the Multimedia-Sprint-2015-03-11 board.Mar 17 2015, 8:25 PM
• Gilles moved this task from Ready for testing to Needs code review on the Multimedia-Sprint-2015-03-11 board.Mar 18 2015, 7:59 AM
gerritbot added a comment.Mar 18 2015, 8:22 AM

Change 196557 merged by jenkins-bot:
Fix flickr import button visibility

https://gerrit.wikimedia.org/r/196557

• Gilles moved this task from Needs code review to Ready for testing on the Multimedia-Sprint-2015-03-11 board.Mar 18 2015, 8:22 AM
• Gilles added a comment.Mar 18 2015, 9:09 AM

It seems like everybody has flickr upload rights on commons beta as well as testwiki, we'll have to wait until this is live in production to confirm the fix.

Steinsplitter subscribed.Mar 18 2015, 11:06 AM
In T89012#1127926, @Gilles wrote:

It seems like everybody has flickr upload rights on commons beta as well as testwiki, we'll have to wait until this is live in production to confirm the fix.

upload_by_url is restricted on commons (for what i see on Special:UserGroupRights).

Upload wizard has a security issue (review process) and therefore Flickr upload should not be enabled for all users until the bug is fixed.

• Gilles edited projects, added Multimedia-Sprint-2015-03-18; removed Multimedia-Sprint-2015-03-11.Mar 18 2015, 4:14 PM
• Gilles moved this task from Backlog to Ready for testing on the Multimedia-Sprint-2015-03-18 board.Mar 18 2015, 4:17 PM
• Gilles merged a task: T93181: Share images from Flickr visible in Upload Wizard for users not having the upload_by_url right.Mar 19 2015, 10:23 AM
• Gilles added a subscriber: Rillke.
Steinsplitter added a subtask: T89131: Server side flickr review.Mar 19 2015, 10:24 AM
Rillke mentioned this in T93181: Share images from Flickr visible in Upload Wizard for users not having the upload_by_url right.Mar 19 2015, 12:18 PM
• Gilles moved this task from Next up to Untriaged on the Multimedia board.Mar 23 2015, 8:55 AM
• Gilles mentioned this in rEUWIb5f59ae526c8: Fix flickr import button visibility.Mar 23 2015, 3:51 PM
• Gilles mentioned this in rMEXT175fbb91fd26: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Mar 23 2015, 3:55 PM
• Gilles closed this task as Resolved.Mar 25 2015, 3:06 PM

Verified in production

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL