Page MenuHomePhabricator

MediaWiki core StoreBatchTest (phpunit) is leaving deep /tmp/storebatch-test-* directory structure behind
Closed, ResolvedPublic

Description

Every test run, a deep structure of storebatch-test-*-temp is created in the configured temporary directory (e.g. /tmp or /mnt/home/jenkins-deploy/tmpfs/).

While it seems to properly unlink the binary files (jpg, png), the hashed directories and .htaccess and index.html markers are left behind.

drwxr-xr-x   5 jenkins-deploy wikidev  120 Feb  4 23:56 storebatch-test-1423094205-638321053-temp/
drwxr-xr-x   5 jenkins-deploy wikidev  120 Feb  5 00:06 storebatch-test-1423094810-1162118272-temp/
drwxr-xr-x   5 jenkins-deploy wikidev  120 Feb  5 01:13 storebatch-test-1423098780-895069919-temp/
drwxr-xr-x   5 jenkins-deploy wikidev  120 Feb  5 01:20 storebatch-test-1423099201-387292791-temp/
drwxr-xr-x   5 jenkins-deploy wikidev  120 Feb  5 01:21 storebatch-test-1423099266-1967273299-temp/
drwxr-xr-x   5 jenkins-deploy wikidev  120 Feb  5 01:29 storebatch-test-1423099779-512393720-temp/
drwxr-xr-x   5 jenkins-deploy wikidev  120 Feb  5 01:43 storebatch-test-1423100624-229689495-temp/
drwxr-xr-x   5 jenkins-deploy wikidev  120 Feb  5 03:10 storebatch-test-1423105802-2141582381-temp/
drwxr-xr-x   5 jenkins-deploy wikidev  120 Feb  5 04:17 storebatch-test-1423109841-754609417-temp/
drwxr-xr-x   5 jenkins-deploy wikidev  120 Feb  5 12:50 storebatch-test-1423140616-3904041-temp/
drwxr-xr-x   5 jenkins-deploy wikidev  120 Feb  5 12:56 storebatch-test-1423141016-344570649-temp/
drwxr-xr-x   5 jenkins-deploy wikidev  120 Feb  5 19:57 storebatch-test-1423166234-435859412-temp/
drwxr-xr-x   5 jenkins-deploy wikidev  120 Feb  6 18:49 storebatch-test-1423248545-1491524167-temp/
drwxr-xr-x   5 jenkins-deploy wikidev  120 Feb  6 19:53 storebatch-test-1423252438-1656243663-temp/
/mnt/home/jenkins-deploy/tmpfs/mediawiki-phpunit-hhvm/storebatch-test-1423549480-1193837997-temp
$ tree -a
.
├── .htaccess
├── 0
│   └── 06
│       └── index.html
├── 3
│   └── 31
│       └── index.html
└── 4
    └── 4d
        └── index.html

6 directories, 4 files

Event Timeline

Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added a project: MediaWiki-Core-Tests.
Krinkle added a subscriber: Krinkle.
gerritbot added a subscriber: gerritbot.

Change 189685 had a related patch set uploaded (by Krinkle):
filerepo: Use built-in temp dir creator and remover

https://gerrit.wikimedia.org/r/189685

Patch-For-Review

Krinkle triaged this task as Medium priority.
Krinkle set Security to None.
Krinkle removed a subscriber: gerritbot.

Change 189685 merged by jenkins-bot:
filerepo: Use standard method for creating temp dir in unit test

https://gerrit.wikimedia.org/r/189685