Page MenuHomePhabricator

UserTuple: User has both id and ip
Closed, ResolvedPublic

Description

Spotted in production:

2015-02-10 15:32:25 mw1255 metawiki: [2dd273da] /w/index.php?title=Special%3AContributions%2F<foo>&offset=&limit=250&printable=yes&target=<foo>   Flow\Exception\InvalidDataException from line 55 of /srv/mediawiki/php-1.25wmf15/extensions/Flow/includes/Model/UserTuple.php: User has both id and ip
#0 /srv/mediawiki/php-1.25wmf15/extensions/Flow/includes/Model/UserTuple.php(84): Flow\Model\UserTuple->__construct()
#1 /srv/mediawiki/php-1.25wmf15/extensions/Flow/includes/Model/AbstractRevision.php(141): Flow\Model\UserTuple::newFromArray()
#2 /srv/mediawiki/php-1.25wmf15/extensions/Flow/includes/Model/PostRevision.php(147): Flow\Model\AbstractRevision::fromStorageRow()
#3 (): Flow\Model\PostRevision::fromStorageRow()
#4 /srv/mediawiki/php-1.25wmf15/extensions/Flow/includes/Data/Mapper/CachingObjectMapper.php(89): call_user_func()
#5 /srv/mediawiki/php-1.25wmf15/extensions/Flow/includes/Data/ObjectLocator.php(295): Flow\Data\Mapper\CachingObjectMapper->fromStorageRow()
#6 /srv/mediawiki/php-1.25wmf15/extensions/Flow/includes/Data/ObjectManager.php(303): Flow\Data\ObjectLocator->load()
#7 /srv/mediawiki/php-1.25wmf15/extensions/Flow/includes/Data/ObjectLocator.php(96): Flow\Data\ObjectManager->load()
#8 (): Flow\Data\ObjectLocator->findMulti()
#9 /srv/mediawiki/php-1.25wmf15/extensions/Flow/includes/Data/ManagerGroup.php(129): call_user_func_array()
#10 /srv/mediawiki/php-1.25wmf15/extensions/Flow/includes/Data/ManagerGroup.php(145): Flow\Data\ManagerGroup->call()
#11 /srv/mediawiki/php-1.25wmf15/extensions/Flow/includes/Formatter/AbstractQuery.php(125): Flow\Data\ManagerGroup->findMulti()
#12 /srv/mediawiki/php-1.25wmf15/extensions/Flow/includes/Formatter/ContributionsQuery.php(70): Flow\Formatter\AbstractQuery->loadMetadataBatch()
#13 /srv/mediawiki/php-1.25wmf15/extensions/Flow/Hooks.php(633): Flow\Formatter\ContributionsQuery->getResults()
#14 /srv/mediawiki/php-1.25wmf15/includes/Hooks.php(209): FlowHooks::onContributionsQuery()
#15 /srv/mediawiki/php-1.25wmf15/includes/specials/SpecialContributions.php(753): Hooks::run()
#16 /srv/mediawiki/php-1.25wmf15/includes/pager/IndexPager.php(222): ContribsPager->reallyDoQuery()
#17 /srv/mediawiki/php-1.25wmf15/includes/pager/IndexPager.php(554): IndexPager->doQuery()
#18 /srv/mediawiki/php-1.25wmf15/includes/specials/SpecialContributions.php(197): IndexPager->getNumRows()
#19 /srv/mediawiki/php-1.25wmf15/includes/specialpage/SpecialPage.php(383): SpecialContributions->execute()
#20 /srv/mediawiki/php-1.25wmf15/includes/specialpage/SpecialPageFactory.php(581): SpecialPage->run()
#21 /srv/mediawiki/php-1.25wmf15/includes/MediaWiki.php(270): SpecialPageFactory::executePath()
#22 /srv/mediawiki/php-1.25wmf15/includes/MediaWiki.php(556): MediaWiki->performRequest()
#23 /srv/mediawiki/php-1.25wmf15/includes/MediaWiki.php(420): MediaWiki->main()
#24 /srv/mediawiki/php-1.25wmf15/index.php(46): MediaWiki->run()
#25 /srv/mediawiki/w/index.php(3): include()
#26 {main}

Event Timeline

demon raised the priority of this task from to Needs Triage.
demon updated the task description. (Show Details)
demon added subscribers: demon, Aklapper.

I've manually purged caches for all pages where Flow is enabled - phew that was boring, luckily we're not on more yet!

I *think* the problem should be gone now, because I *think* the problem was with outdated caches.
If this problem still happens, we'll need to do some programming, but for now I'll consider this fixed.

I'll check logs again in a couple of days.

Can't seem to find this in exception logs anymore