Page MenuHomePhabricator

SearchHighlighter::highlightText() should not be checking if Cite is installed
Open, HighPublic

Description

		// @todo FIXME: This should prolly be a hook or something
		// instead of hardcoding the name of the Cite extension
		if ( \ExtensionRegistry::getInstance()->isLoaded( 'Cite' ) ) {
			$spat .= '|(<ref>)'; // references via cite extension
			$endPatterns[4] = '/(<ref>)|(<\/ref>)/';
		}

Event Timeline

Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added a subscriber: Legoktm.

Change 530184 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/core@master] Use ExtensionRegistry instead of class name

https://gerrit.wikimedia.org/r/530184

Change 530184 merged by jenkins-bot:
[mediawiki/core@master] Use ExtensionRegistry instead of class name

https://gerrit.wikimedia.org/r/530184

Gehel triaged this task as High priority.Aug 28 2020, 8:35 AM
Gehel moved this task from elastic / cirrus to Bugs on the Discovery-Search board.
Gehel added a subscriber: Gehel.

It is unclear to me just glancing at the attached CR if this is the complete fix, or if there is more work needed. We should at least clarify the status and either close or re-prioritize this task.