Create check hook before really uploading file with infos about description page and file
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Se4598
	Feb 11 2015, 11:15 PM

Description

I haven't found a hook that provides me the file, the wikitext and comment for the description page.

Neither UploadVerification nor UploadVerifyFile doesn't seem to include the necessary description page infos and UploadComplete is too late as file was already uploaded and page created.
and UploadForm:BeforeProcessing doesn't allow nice abort.

I think ideally the hook would run right at the start of UploadBase::performUpload and gets the file, pagetext etc. with the ability to cancel the upload.

Needed for AbuseFilter, T89252.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Introduce new hook UploadVerifyUpload to allow preventing file uploads	mediawiki/core	master	+38 -6

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	matmarex	T138273 Make AbuseFilter support a filter for cross-wiki uploads
Resolved	matmarex	T139848 Make variable "summary" and/or tag available in action "upload"
Resolved	matmarex	T89252 ABF is ignoring wikitext during upload
Resolved	matmarex	T87381 AbuseFilter should not treat uploads to stash the same as real uploads
Resolved	matmarex	T89302 Create check hook before really uploading file with infos about description page and file

Event Timeline

Se4598 created this task.Feb 11 2015, 11:15 PM

Se4598 raised the priority of this task from to Medium.

Se4598 updated the task description. (Show Details)

Se4598 added a project: MediaWiki-Uploading.

Se4598 subscribed.

Restricted Application added a project: Multimedia. · View Herald TranscriptFeb 11 2015, 11:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Krenair subscribed.Feb 12 2015, 1:03 AM

Se4598 updated the task description. (Show Details)Feb 12 2015, 1:08 AM

Se4598 set Security to None.

Se4598 mentioned this in T21565: Add more variables to AbuseFilter file uploading evaluation.Apr 6 2015, 7:34 PM

Steinsplitter added subscribers: Rillke, MarkTraceur, Bawolff.Apr 7 2015, 9:12 AM

Steinsplitter subscribed.

Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:25 PM

Restricted Application added a subscriber: Matanya. · View Herald TranscriptSep 4 2015, 6:25 PM

matmarex added a parent task: T87381: AbuseFilter should not treat uploads to stash the same as real uploads.Apr 18 2016, 9:06 PM

matmarex claimed this task.Jun 16 2016, 1:28 PM

matmarex added a parent task: T137961: Uploads blocked by AbuseFilter should be reported with a different error in the API than 'verification-error'.

matmarex raised the priority of this task from Medium to High.Jun 17 2016, 12:14 PM

Change 295252 had a related patch set uploaded (by Bartosz Dziewoński):
Introduce new hook UploadVerifyUpload to allow preventing file uploads

https://gerrit.wikimedia.org/r/295252

gerritbot added a project: Patch-For-Review.Jun 20 2016, 5:59 PM

matmarex removed a parent task: T137961: Uploads blocked by AbuseFilter should be reported with a different error in the API than 'verification-error'.Jun 20 2016, 6:06 PM

matmarex mentioned this in T137961: Uploads blocked by AbuseFilter should be reported with a different error in the API than 'verification-error'.Jun 20 2016, 6:23 PM

Some of the changes I'm making will change the action=upload responses for non-hook-related errors slightly, for example:

Before

After

P3285 (An Untitled Masterwork)

1	{
2	"error": {
3	"code": "internal-error",
4	"info": "An internal error occurred",
5	"0": [
6	"directorycreateerror",
7	"mwstore://local-backend/local-public/a/ad"
8	],
9	"*": "See http://localhost:3080/w/api.php for API usage"
10	}
11	}

P3284 (An Untitled Masterwork)

1	{
2	"error": {
3	"code": "internal-error",
4	"info": "Unknown error: \"directorycreateerror\"",
5	"0": [
6	"directorycreateerror",
7	"mwstore://local-backend/local-public/a/ad"
8	],
9	"stashfailed": "Stashing temporary file failed: UploadStashFileException Error storing file in '/tmp/phpLn0Uqt': Directory \"mwstore://local-backend/local-temp/4/4d\" is read-only.",
10	"invalidparameter": null,
11	"*": "See http://localhost:3080/w/api.php for API usage"
12	}
13	}