Page MenuHomePhabricator
Create Task
Maniphest T89412

Client-side validation breaks credit card button on GC forms
Open, LowPublic
Actions

Description

Steps to reproduce:

  • Go to a GlobalCollect donation form.
  • Enter stuff. Make the email address invalid, like "s".
  • Click Visa.
  • You'll see the "invalid email address" dialog.
  • Correct the email address, enter something valid.
  • Click Visa again.

Nothing happens!! You can click another credit card type, but the Visa button will not work until the form is refreshed.

Event Timeline

awight created this task.Feb 12 2015, 11:26 PM
awight raised the priority of this task from to Needs Triage.
awight updated the task description. (Show Details)
awight added projects: MediaWiki-extensions-DonationInterface, Wikimedia-Fundraising, Fundraising-Backlog-Old.
awight subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2015, 11:26 PM
• atgo subscribed.Feb 12 2015, 11:46 PM

@awight I believe this is why the "continue" button appears. Are you saying that there's no solution or that what we have is inelegant?

awight added a comment.Feb 12 2015, 11:51 PM

Oh, interesting... Well, now that the radio buttons are styled like pushbuttons, they should have behavior consistent with buttons. All we have to do is rewrite the "onChange" event handler to run "onClick".

• atgo triaged this task as Low priority.Feb 12 2015, 11:52 PM
• atgo set Security to None.

Thanks! Given that this isn't blocking payments, I'm rating it low. I agree we should do something about it when we have a chance though.

• atgo added a project: Fundraising-Backlog.Jul 30 2015, 10:14 PM
• atgo removed a project: Wikimedia-Fundraising.Jul 30 2015, 10:42 PM
• atgo renamed this task from Client-side validation breaks credit card button to Client-side validation breaks credit card button on GC forms.Jul 31 2015, 9:09 PM
• atgo moved this task from Triage to Old Unscheduled (prior to 2019) on the Fundraising-Backlog board.
• atgo unsubscribed.Mar 30 2016, 10:07 PM
• DStrine removed a project: Fundraising-Backlog-Old.Aug 5 2016, 8:41 PM
• mmodell removed a subscriber: awight.Jun 22 2017, 9:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL