Maniphest T89428

Flow logging is broken
Closed, ResolvedPublic
Actions

Description

Flow logging seems to be broken. Things that clearly should be logged (and the code has setup for this), such as deletion of topics and posts, does not make it through.

I first noticed this on my local machine, but the same is true on Beta Labs.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Flow	master	+110 -2	Backfill moderation (delete, suppress) logging that was dropped
	mediawiki/extensions/Flow	master	+16 -5	Wire up moderation logging listener

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		EBernhardson	T89428 Flow logging is broken
		Resolved		• Mattflaschen-WMF	T89504 Write maintenance script to recover lost moderation logs
		Resolved		• Mattflaschen-WMF	T90813 Run FlowAddMissingModerationLogs on production wikis after it is deployed

Event Timeline

• Mattflaschen-WMF created this task.Feb 13 2015, 4:46 AM

• Mattflaschen-WMF raised the priority of this task from to Unbreak Now!.

• Mattflaschen-WMF updated the task description. (Show Details)

• Mattflaschen-WMF added projects: StructuredDiscussions, Collaboration-Team-Sprint-Q-2015-02-25.

• Mattflaschen-WMF added a subscriber: • Mattflaschen-WMF.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2015, 4:46 AM

It does go in the history, but not to Special:Log.

EBernhardson moved this task from Sprint Q - ends Feb 25 to In Development on the Collaboration-Team-Sprint-Q-2015-02-25 board.Feb 13 2015, 6:01 PM

EBernhardson moved this task from In Development to Code Review on the Collaboration-Team-Sprint-Q-2015-02-25 board.Feb 13 2015, 7:07 PM

Change 190497 had a related patch set uploaded (by EBernhardson):
Wire up moderation logging listener

https://gerrit.wikimedia.org/r/190497

Patch-For-Review

• Mattflaschen-WMF mentioned this in T89504: Write maintenance script to recover lost moderation logs.Feb 13 2015, 10:31 PM

EBernhardson claimed this task.Feb 18 2015, 6:07 PM

EBernhardson set Security to None.

EBernhardson moved this task from Code Review to In Development on the Collaboration-Team-Sprint-Q-2015-02-25 board.

EBernhardson moved this task from In Development to Code Review on the Collaboration-Team-Sprint-Q-2015-02-25 board.Feb 18 2015, 10:59 PM

Change 191543 had a related patch set uploaded (by Mattflaschen):
WIP: Backfill moderation (delete, suppress) logging that was dropped

https://gerrit.wikimedia.org/r/191543

Patch-For-Review

Change 190497 merged by jenkins-bot:
Wire up moderation logging listener

https://gerrit.wikimedia.org/r/190497

EBernhardson mentioned this in rEFLW218b8e28a57e: Wire up moderation logging listener.Feb 19 2015, 4:09 PM

matthiasmullie moved this task from Code Review to Product Review on the Collaboration-Team-Sprint-Q-2015-02-25 board.Feb 20 2015, 2:19 PM

• Mattflaschen-WMF mentioned this in T90319: Lock logging is completely unformatted.Feb 21 2015, 2:50 AM

DannyH closed this task as Resolved.Feb 24 2015, 5:15 PM

DannyH added a subscriber: DannyH.

Change 191543 merged by jenkins-bot:
Backfill moderation (delete, suppress) logging that was dropped

https://gerrit.wikimedia.org/r/191543

• Mattflaschen-WMF closed subtask T89504: Write maintenance script to recover lost moderation logs as Resolved.Feb 24 2015, 8:40 PM

• Mattflaschen-WMF mentioned this in rEFLW243040d3e34d: Backfill moderation (delete, suppress) logging that was dropped.

We still need to run the backfill script in prod.

• Mattflaschen-WMF closed subtask T90813: Run FlowAddMissingModerationLogs on production wikis after it is deployed as Resolved.Mar 6 2015, 4:12 AM

DannyH added a project: Collaboration-Team-Sprint-R-2015-03-11.Mar 9 2015, 5:51 PM

DannyH moved this task from Sprint R - ends March 11 to Code Review Started on the Collaboration-Team-Sprint-R-2015-03-11 board.

Judging by T90813, that script has now been run. Everything should be fine by now.

matthiasmullie moved this task from Code Review Started to Product Review on the Collaboration-Team-Sprint-R-2015-03-11 board.Mar 10 2015, 5:01 PM

EBernhardson closed this task as Resolved.Mar 10 2015, 5:44 PM

Diffusion mentioned this in rMEXTacbdd1f35f59: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 11 2015, 6:27 AM

Diffusion mentioned this in rMEXT67b4cc790e0b: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….