Spotted in production a number of times:
No such file or directory in /srv/mediawiki/php-1.25wmf16/includes/resourceloader/ResourceLoaderImage.php on line 348
This happens when we fail to convert the SVG to PNG. The actual error happens when attempting to access the non-existing temp PNG from the conversion. The rasterize() function call should let us know, ResourceLoaderImage should handle the failure more gracefully.
I would like to point out that this code specifically special-cases rsvg and thus like 348 shouldn't be executed in WMF production at all. Why is it being executed?
So in ResourceLoaderImage::rasterize we create a file and store it's name in $tempFilenamePng, which we then assume to exist afterwards, and try to call file_get_contents.
Except in this case, the SvgHandler::rasterize call goes to MediaHandler::removeBadFile which finds it's actually got a size of 0 according to stat(), so it's deleted:
2015-02-13 21:25:42 mw1104 enwiki: Removing bad 0-byte thumbnail "/tmp/ResourceLoaderImageLGQKSa". unlink() succeeded
And SvgHandler returns a MediaTransformError, but ResourceLoaderImage does not handle it.
Edit: Oh, yeah, here's the other interesting warning that came up in a grep for @Chad's temp file:
2015-02-13 21:25:42 mw1104 enwiki: thumbnail failed on mw1104: error 1 "Unknown option --no-external-files" from "'/usr/bin/'rsvg-convert --no-external-files -w 512 -h 512 -o '/tmp/ResourceLoaderImageLGQKSa' '/tmp/ResourceLoaderImage8nzo4N'"
krenair@tin:/srv/mediawiki-staging$ mwscript eval.php --wiki=enwiki > var_dump( $wgSVGConverter ); string(11) "rsvg-secure"
Change 191383 had a related patch set uploaded (by Chad):
ResourceLoaderImage: tighten up svg handling
Change 191502 had a related patch set uploaded (by Chad):
ResourceLoaderImage: tighten up svg handling
Change 191503 had a related patch set uploaded (by Chad):
ResourceLoaderImage: tighten up svg handling