Page MenuHomePhabricator

Get rid of artifical click delay in MediaViewer
Closed, ResolvedPublic0 Estimated Story Points

Description

Navigation on clicks leading away from the current page is artifically delayed in MediaViewer to protect EventLogging requests. Now that EventLogging supports sendBeacon, this should no longer be necessary.

Event Timeline

Tgr created this task.Feb 14 2015, 2:07 AM
Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added projects: MediaViewer, Analytics.
Tgr added a subscriber: Tgr.
Restricted Application added a project: Multimedia. · View Herald TranscriptFeb 14 2015, 2:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr added a comment.Feb 14 2015, 2:53 AM
This comment was removed by Tgr.
Tgr added a comment.Feb 14 2015, 2:58 AM
This comment was removed by Tgr.
gerritbot added a subscriber: gerritbot.

Change 190703 had a related patch set uploaded (by Gergő Tisza):
Fix share tabs

https://gerrit.wikimedia.org/r/190703

Patch-For-Review

Tgr added a comment.Feb 15 2015, 6:13 AM

Oops, mixed up the bugs.

Tgr added a comment.Feb 15 2015, 6:33 AM

Nevermind, wasn't originating from MediaViewer. I removed the preventDefault-based click delay though.

Change 190705 had a related patch set uploaded (by Gergő Tisza):
Remove delay when logging link clicks

https://gerrit.wikimedia.org/r/190705

Patch-For-Review

Gilles assigned this task to Tgr.Feb 18 2015, 10:01 AM
Gilles moved this task from Untriaged to Reviewed, needs improvements on the Multimedia board.
Gilles added a subscriber: Gilles.

This task ought to be renamed.

Gilles set Security to None.Feb 18 2015, 10:22 AM
Gilles edited a custom field.
Tgr renamed this task from Get rid of sync AJAX calls in MediaViewer to Get rid of artifical click delay in MediaViewer.Feb 18 2015, 8:05 PM
Tgr updated the task description. (Show Details)

Change 190705 merged by jenkins-bot:
Remove delay when logging link clicks

https://gerrit.wikimedia.org/r/190705