Page MenuHomePhabricator

License URLs in VisualEditor media insertion dialog are broken
Closed, ResolvedPublic1 Estimated Story Points

Description

Steps to reproduce:

  1. Insert media in latest version of VE
  2. Select a file that has a license with a URL (e.g. CC-BY, CC-BY-SA)

Expected result:

  • License link is correctly displayed in the image preview

Actual result:

  • Link points to URL of wiki+"[object Object]"

(Tested in Chrome)

Event Timeline

Eloquence raised the priority of this task from to Needs Triage.
Eloquence updated the task description. (Show Details)
Eloquence added a project: VisualEditor.
Eloquence added a subscriber: Eloquence.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.
gerritbot added a subscriber: gerritbot.

Change 190952 had a related patch set uploaded (by Mooeypoo):
Correct the license URL in the media dialog

https://gerrit.wikimedia.org/r/190952

Patch-For-Review

Change 190952 merged by jenkins-bot:
Correct the license URL in the media dialog

https://gerrit.wikimedia.org/r/190952

Checked in betalabs.

In test2, e.g.
CC-BY-SA 2.5 points to

<a href="http://creativecommons.org/licenses/by-sa/2.5" rel="mw:ExtLink" target="_blank">CC BY-SA 2.5</a>