Page MenuHomePhabricator

Main Page has 100% high edit button
Closed, ResolvedPublic

Description

It looks like https://gerrit.wikimedia.org/r/#/c/189506/ didn't take into account the Main Page special formatting. If the main page includes something like...

<div id="mf-tfa">
== Header ==
</div>

...which is common, it will end up with a 100% high edit button on the side of the page (taking up the entire height of the window).

Also, I think this change needs approval from product and design before being deployed in stable mode.

Event Timeline

kaldari raised the priority of this task from to Needs Triage.
kaldari updated the task description. (Show Details)
kaldari added a project: Readers-Web-Backlog.
kaldari added a subscriber: kaldari.
gerritbot added a subscriber: gerritbot.

Change 190662 had a related patch set uploaded (by Kaldari):
Revert "Show edit pencil on all headings"

https://gerrit.wikimedia.org/r/190662

Patch-For-Review

Florian set Security to None.

Change 190662 abandoned by Kaldari:
Revert "Show edit pencil on all headings"

Reason:
Florian has another plan...

https://gerrit.wikimedia.org/r/190662

Change 190663 had a related patch set uploaded (by Florianschmidtwelzow):
Don't show edit pencils on main page

https://gerrit.wikimedia.org/r/190663

Patch-For-Review

Change 190663 merged by jenkins-bot:
Don't show edit pencils on main page

https://gerrit.wikimedia.org/r/190663

Change 190984 had a related patch set uploaded (by Florianschmidtwelzow):
Don't show edit pencils on main page

https://gerrit.wikimedia.org/r/190984

Patch-For-Review

Change 190984 merged by jenkins-bot:
Don't show edit pencils on main page

https://gerrit.wikimedia.org/r/190984