Page MenuHomePhabricator
Create Task
Maniphest T89631

MediaViewer crops bottom of images
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Reported on-wiki:

Win 7: IE 11 & Chrome 40

In both IE and Chrome, MV loses a significant portion from the bottom of the picture it is displaying. I'm surprised that I (or no one else) hasn't noticed this before, so perhaps it is a new bug inadvertently caused by some other change. Additionally, in Chrome, toolbars obscure the top of the image (MV seems to be using the wrong number to calculate screen extent -- one that does not allow for the space taken by toolbars).

File:H2_tiling_23i-1.png in IE:

mmv_crop_error_1.jpg (768×1 px, 154 KB)

Chrome:

mmv_crop_error_3.jpg (765×1 px, 177 KB)

Can reproduce in Chrome 40/Ubuntu; possibly related to the recent removal of max-height which masked some calculation error.

Details

SubjectRepoBranchLines +/-
Fix canvas height calculationmediawiki/extensions/MultimediaViewerwmf/1.25wmf17+1 -1
Fix canvas height calculationmediawiki/extensions/MultimediaViewerwmf/1.25wmf18+1 -1
Fix canvas height calculationmediawiki/extensions/MultimediaViewermaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 InvalidNoneT78211 MediaViewer image/screen sizing problems (tracking)
 ResolvedNoneT89631 MediaViewer crops bottom of images

Event Timeline

Tgr created this task.Feb 16 2015, 6:21 AM
Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added a project: MediaViewer.
Tgr subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptFeb 16 2015, 6:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr added a parent task: T78211: MediaViewer image/screen sizing problems (tracking).Feb 16 2015, 6:22 AM
Tgr updated the task description. (Show Details)Feb 16 2015, 6:25 AM
Tgr set Security to None.
Liuxinyu970226 subscribed.Feb 16 2015, 6:26 AM
• Gilles added a project: Multimedia-Sprint-2015-02-18.Feb 16 2015, 3:52 PM
• Gilles subscribed.
Tgr renamed this task from MediaViewer crops images in Chrome 40 and IE 11 on Win7 to MediaViewer crops bottom of images.Feb 16 2015, 10:04 PM
Tgr triaged this task as Unbreak Now! priority.
Tgr updated the task description. (Show Details)
Tgr edited a custom field.Feb 18 2015, 1:06 AM
Tgr edited a custom field.Feb 18 2015, 1:13 AM
Tgr claimed this task.Feb 18 2015, 5:52 PM
Tgr merged a task: T89935: MediaViewer footer overlaps bottom ~31 pixels of images.Feb 19 2015, 7:13 AM
Tgr added a subscriber: kaldari.
gerritbot subscribed.Feb 19 2015, 7:23 AM

Change 191545 had a related patch set uploaded (by Gergő Tisza):
Fix canvas height calculation

https://gerrit.wikimedia.org/r/191545

Patch-For-Review

Tgr moved this task from Backlog to Needs code review on the Multimedia-Sprint-2015-02-18 board.Feb 19 2015, 7:27 AM
gerritbot added a comment.Feb 19 2015, 8:53 AM

Change 191545 merged by jenkins-bot:
Fix canvas height calculation

https://gerrit.wikimedia.org/r/191545

Tgr mentioned this in rEMMV3bb2b8185a45: Fix canvas height calculation.Feb 19 2015, 8:53 AM
• Gilles moved this task from Needs code review to Ready for testing on the Multimedia-Sprint-2015-02-18 board.Feb 19 2015, 8:53 AM
Tgr added a comment.EditedFeb 20 2015, 11:17 PM

Needs backport (scheduled).

gerritbot added a comment.Feb 20 2015, 11:44 PM

Change 192025 had a related patch set uploaded (by Gergő Tisza):
Fix canvas height calculation

https://gerrit.wikimedia.org/r/192025

Patch-For-Review

gerritbot added a comment.Feb 20 2015, 11:45 PM

Change 192027 had a related patch set uploaded (by Gergő Tisza):
Fix canvas height calculation

https://gerrit.wikimedia.org/r/192027

Patch-For-Review

gerritbot added a comment.Feb 20 2015, 11:53 PM

Change 192025 merged by jenkins-bot:
Fix canvas height calculation

https://gerrit.wikimedia.org/r/192025

gerritbot added a comment.Feb 20 2015, 11:54 PM

Change 192027 merged by jenkins-bot:
Fix canvas height calculation

https://gerrit.wikimedia.org/r/192027

Tgr mentioned this in rEMMV7e1dcc77f776: Fix canvas height calculation.Feb 20 2015, 11:55 PM
Tgr mentioned this in rEMMVe3da4d9094ee: Fix canvas height calculation.
FriedhelmW merged a task: T87515: Attached images not properly centered in viewport.Feb 21 2015, 3:33 PM
FriedhelmW subscribed.
FriedhelmW merged a task: T78075: Image viewer footer is not correctly anchored, obscures lowest / bottom part of the image.Feb 21 2015, 3:36 PM
FriedhelmW added subscribers: • Jaredzimmerman-WMF, Qgil.
Qgil mentioned this in T78075: Image viewer footer is not correctly anchored, obscures lowest / bottom part of the image.Feb 21 2015, 6:21 PM
Qgil mentioned this in T87515: Attached images not properly centered in viewport.
Aklapper added a comment.Feb 23 2015, 12:04 PM

Is there anything left to do here? All patches seem to be merged...

Tgr lowered the priority of this task from Unbreak Now! to High.Feb 24 2015, 12:39 AM

Backported. There is still a tiny (1px?) clipping sometimes, but only on some files on some pages. Compare:

Tgr moved this task from Ready for testing to Reviewed, needs improvements on the Multimedia-Sprint-2015-02-18 board.Feb 24 2015, 12:39 AM
• Gilles added a project: Multimedia-Sprint-2015-02-25.Feb 25 2015, 10:59 AM
• Gilles moved this task from Backlog to Reviewed, needs improvements on the Multimedia-Sprint-2015-02-25 board.
• Gilles added a comment.Feb 25 2015, 12:14 PM

That last one with the same file is puzzling. The only difference I can spot is that in one case there's a left paddle because it's not the first image on the page, in the second case there isn't because we're on the file page.

I tried isolating this difference and it's not the cause:
https://en.wikipedia.org/wiki/User:GDubuc_%28WMF%29/cubetest#mediaviewer/File:Uniform_tiling_74-t01.png

These tests in a vacuum show the correct unclipped version.

Must be something on that article, or a timing issue.

• Gilles moved this task from Reviewed, needs improvements to Backlog on the Multimedia-Sprint-2015-02-25 board.Feb 25 2015, 12:14 PM
Qgil unsubscribed.Feb 25 2015, 12:22 PM
• Gilles removed a project: Multimedia-Sprint-2015-02-25.Feb 25 2015, 5:57 PM
Tgr added a comment.Feb 25 2015, 7:58 PM

I don't think it's a timing issue, it's very deterministic on multiple sites and browsers. Also it's the size of the image that is wrong, so it's not a local CSS difference (or only to the extent that it confuses size calculation - .mw-mmv-above-fold has the exact same dimensions though).

Anyway this is mild enough that we can leave it for later.

• Gilles removed a project: Multimedia-Sprint-2015-02-18.Feb 25 2015, 8:54 PM
Aklapper added a comment.Mar 3 2015, 1:59 PM

Is any further work planned here "soon" (as it's not part of any sprint but still priority=high)?

• Gilles lowered the priority of this task from High to Low.Mar 3 2015, 2:17 PM

Lowering the priority, this is now only 1 or 2 pixels of height being cut off sometimes, it was originally a significant portion of the image.

Liuxinyu970226 unsubscribed.Mar 5 2015, 3:39 AM
Tgr mentioned this in rMEXTf8ba2b9a83c1: Updated mediawiki/extensions Project: mediawiki/extensions/MultimediaViewer….Mar 11 2015, 6:27 AM
Tgr removed Tgr as the assignee of this task.Apr 3 2015, 6:21 AM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 5:53 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptSep 4 2015, 5:53 PM
Jdforrester-WMF subscribed.Sep 21 2015, 3:39 PM

Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Multimedia team.

Jdforrester-WMF removed a project: Multimedia.Sep 21 2015, 3:49 PM
MBinder_WMF added a project: Web-Team-Backlog.Apr 27 2016, 4:26 PM
MBinder_WMF moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jul 4 2016, 7:38 PM
Jdforrester-WMF unsubscribed.Jul 5 2016, 9:24 AM
MBinder_WMF removed a project: Web-Team-Backlog.Apr 13 2017, 6:39 PM
MBinder_WMF added a project: Multimedia.Aug 7 2017, 5:47 PM
Tgr unsubscribed.Jul 9 2019, 6:03 PM
Aklapper moved this task from Backlog to Image/screen size on the MediaViewer board.Mar 16 2022, 11:37 AM
matmarex closed this task as Resolved.May 2 2023, 1:30 PM
matmarex subscribed.

This seems to have been fixed back in 2015.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL