Page MenuHomePhabricator
Create Task
Maniphest T89648

Implement MalformedTextException in JS and throw from mw.Title construtor
Closed, DeclinedPublic
Actions

Description

In T87314#992696, @Tgr wrote:

UW checks whether mw.Title.newFromText() is successful, and that function just returns false whether the title is too long or has invalid characters or whatever else, so I would say this has to be solved in core. (Not sure how though - maybe by mw.Title providing a validator that uses the same logic but returns error codes?)

Port MalformedTitleException to JS and throw from constructor for mw.Title so we know why a Title is unparseable.

Details

SubjectRepoBranchLines +/-
Implement MalformedTitleException for JS and use in constructormediawiki/coremaster+50 -15
mediawiki.Title: Load messages for specific MalformedTitleExceptionsmediawiki/coremaster+9 -0
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
DuplicateSn1perT87314 Special:UploadWizard gives undescriptive error message upon too long filename
DeclinedSn1perT89648 Implement MalformedTextException in JS and throw from mw.Title construtor
· · ·

Event Timeline

Sn1per created this task.Feb 16 2015, 2:05 PM
Sn1per claimed this task.
Sn1per raised the priority of this task from to Low.
Sn1per updated the task description. (Show Details)
Sn1per added projects: Multimedia, UploadWizard.
Sn1per edited projects, added MediaWiki-General; removed UploadWizard.
Sn1per set Security to None.
Sn1per added subscribers: Tgr, Sn1per, Lokal_Profil, Aklapper.
Aklapper lowered the priority of this task from Low to Lowest.Feb 16 2015, 5:42 PM
Aklapper edited projects, added MediaWiki-Parser; removed MediaWiki-General, Multimedia.
Aklapper removed a subscriber: Tgr.
• brion subscribed.Feb 17 2015, 7:02 PM

IMO the proper fix is to not be trying to squeeze a user-submitted text description into the filename in the first place... filenames are hard to change and impossible to localize, so using 'human-readable descriptions' as filenames turned out to be a bad idea in practice.

Sn1per updated the task description. (Show Details)May 15 2015, 12:22 AM
Sn1per added subscribers: • Mattflaschen-WMF, Tgr.
Sn1per removed a subscriber: Tgr.
Sn1per renamed this task from Implement Title validator that returns error codes to Implement newFromTextThrow and MalformedTextException in JS.May 15 2015, 12:28 AM
Sn1per updated the task description. (Show Details)
Sn1per added a subscriber: Tgr.
Sn1per removed a subscriber: Tgr.
gerritbot subscribed.May 15 2015, 5:20 AM

Change 211077 had a related patch set uploaded (by Sn1per):
[WIP] Implement Title.newFromTextThrow and MalformedTitleException for JS

https://gerrit.wikimedia.org/r/211077

gerritbot added a project: Patch-For-Review.May 15 2015, 5:20 AM
matmarex subscribed.May 15 2015, 8:31 AM
Krinkle subscribed.May 15 2015, 6:51 PM
In T89648#1044297, @brion wrote:

IMO the proper fix is to not be trying to squeeze a user-submitted text description into the filename in the first place... filenames are hard to change and impossible to localize, so using 'human-readable descriptions' as filenames turned out to be a bad idea in practice.

I agree.

Sn1per renamed this task from Implement newFromTextThrow and MalformedTextException in JS to Implement MalformedTextException in JS and throw from mw.Title construtor.May 22 2015, 2:51 AM
Sn1per updated the task description. (Show Details)
Sn1per added a subscriber: Tgr.
gerritbot added a comment.May 31 2015, 8:12 PM

Change 211077 merged by jenkins-bot:
Implement MalformedTitleException for JS and use in constructor

https://gerrit.wikimedia.org/r/211077

matmarex mentioned this in rMW52bc467b3106: Implement MalformedTitleException for JS and use in constructor.May 31 2015, 8:12 PM
Sn1per closed this task as Resolved.May 31 2015, 8:39 PM
• Forrestbot added projects: WMF-deploy-2015-06-09_(1.26wmf9), MW-1.26-release.May 31 2015, 9:00 PM
• Forrestbot subscribed.
gerritbot added a comment.Jun 2 2015, 4:27 PM

Change 215345 had a related patch set uploaded (by Sn1per):
Load messages in mw.Title for specific MalformedTitleExceptions

https://gerrit.wikimedia.org/r/215345

gerritbot added a comment.Jun 4 2015, 9:43 PM

Change 215345 abandoned by Sn1per:
mediawiki.Title: Load messages for specific MalformedTitleExceptions

Reason:
Not necessary

https://gerrit.wikimedia.org/r/215345

Sn1per changed the task status from Resolved to Declined.Jun 4 2015, 9:47 PM

No use case (see https://gerrit.wikimedia.org/r/#/c/211077/ and https://gerrit.wikimedia.org/r/#/c/215345/)

Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL