Page MenuHomePhabricator

Attempting to play a video when fullscreen mode is previously enabled on an element nested below the <body> element will cause the video to be played but not being visible
Open, MediumPublic

Description

Original task title: Attempting to play a video when fullscreen mode is previously enabled on an element nested below the <body> element will cause the video to be played but not being visible

How to reproduce:
Go to https://commons.wikimedia.org/wiki/Commons:Picture_of_the_Year/2014/R2/Gallery, press "Full screen" (this requires you are running a browser with HTML5 fullscreen support), click a video.

And technically?
Call requestFullscreen() on any element that is nested below the body in the document element tree.

What happens:
A dialogue is opened but one can't see it (only after closing fullscreen) and the video is played (you will hear the sound in supported browsers).

And technically?
The newly opened dialogue (this is a child of the <body> element) is not a descendant of the element requestFullscreen() was called on so it's not visible to the end user.

What's expected behaviour:
Seeing the video playing.

  • TimedMediaHandler could check whether the browser is currently in full screen mode and
    • exit fullscreen mode if the full screen element is different from the required one
    • add the dialogue element to the element that is currently in fullscreen mode instead
    • make the video/ video player the fullscreen element instead

Note: I am using a similar approach for the slideshow button that is next to the fullscreen button. It checks which element is the fullscreen one and if it's not the required one, it will exit fullscreen and enter it with the required element. Maybe the exit step could be omitted (to be tested).

(assigning to myself as I'd possibly interested in fixing it but dear reader, please do not hesitate to grab it)

Event Timeline

Rillke created this task.Feb 16 2015, 11:25 PM
Rillke claimed this task.
Rillke raised the priority of this task from to Needs Triage.
Rillke updated the task description. (Show Details)
Rillke added a project: TimedMediaHandler.
Rillke added a subscriber: Rillke.
Restricted Application added a project: Multimedia. · View Herald TranscriptFeb 16 2015, 11:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Rillke triaged this task as Medium priority.Feb 16 2015, 11:26 PM
Rillke set Security to None.

Normal priority as it rarely happens but is very confusing: "Where is the video, I hear the sound but can't see it!"

brion added a subscriber: brion.Feb 17 2015, 6:50 PM

TMH shouldn't pop up a dialog in the MMV usage I think; it should be showing a player directly inline in the viewer regardless of size. Might need to adjust how TMH is triggered or some internals for the popup/inline distinction?

Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:25 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptSep 4 2015, 6:25 PM
TheDJ moved this task from To sort to Player on the TimedMediaHandler board.Oct 21 2015, 7:26 PM
brion moved this task from Player to Player-Old on the TimedMediaHandler board.Apr 23 2018, 11:01 PM