usernames passed to maintenance/protect.php via --user or -u are ignored and replaced by default "maintenance script". same for --reason and -r (which is always left empty)
fix:
in public function execute() change
44 $userName = $this->getOption( 'u', 'Maintenance script' );
45 $reason = $this->getOption( 'r', '' );
to
44 $userName = $this->getOption( 'user', 'Maintenance script' );
45 $reason = $this->getOption( 'reason', '' );
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Make protect.php maintenance script not ignore --user and --reason parameters | Filip | mediawiki/core | master | +2 -2 |
I'll mentor this as a beginner task in Google-Code-In-2016. https://codein.withgoogle.com/dashboard/tasks/6396571428061184/
@FilipGCI It is preferred if you wait until you can claim the corresponding GCI task before claiming the task here.
@FilipGCI, what @Unicornisaurous is trying to say is that you should first claim a task in GCI website first before claiming it here on phabricator. Hope its clearer now. Thanks and try to do this for all tasks you will work on during the contest.
You have not still claimed the task on the GCI website. Please do claim the task before you proceed.
@FilipGCI, you will have to wait for a while until its reviewed so that you can claim your next task which is this one. Don't stack them up, the mentors have until 36hours to review your work.
Change 324179 merged by jenkins-bot:
Make protect.php maintenance script not ignore --user and --reason parameters