With uploading photos with the uploadwizard I always use Cc-zero as "license". I have uploaded multiple series of photos I recently made, and a part have a different license (cc-by-sa-4.0) and another part has (the correct) cc-zero. I am 100% sure that the uploadwizard showed cc-zero to me with uploading, but some photos automatic got cc-by-sa-4.0.
This bug is occurring for multiple weeks now.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Respect preferences' default license when picking a license per file | mediawiki/extensions/UploadWizard | master | +136 -6 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Gilles | T91651 Significantly increase UploadWizard test coverage | |||
| Resolved | • Gilles | T89717 Default license in preferences not respected for multi-file uploads going through the per-file license picking step |
Another example:
https://commons.wikimedia.org/w/index.php?title=File:Mechelen-Klitserbeek_%287%29.JPG&oldid=150327790
I checked the license and it showed cc-zero before I continued, but it uploads it under cc-by-sa-4.0.
The file of Mechelen-Landeus was part of a group of 4 files I uploaded at once.
The file of Mechelen-Klitserbeek was uploaded on his own.
So far I can't reproduce locally. Uploading 2 files at once and picking different licenses for each, both files get the correct license once published.
Maybe it matters that I have set in my preferences, on tab Upload Wizard as default license for new uploads: Own work - Creative Commons CC0 Waiver (release all rights, like public domain: legal code)
Thank you for the extra information, I can repro. The default set in the preferences is displayed correctly in the UI, but once uploaded it turns into cc-by-sa-4.0
This only happens when uploading multiple files, single file upload works as expected.
In a multi-upload any file left in its default state will end up being cc-by-sa-4.0 regardless of the user's preferences (and regardless of the UI stating that cc-0 is selected by default).
Steps to repro:
I think the issue comes from the extra step to pick a license for each file, and its underlying form. Because is I skip that step for a multiupload, the licenses are cc-0 in the end. And single upload can't have that step, which is why it works.
I'm pretty sure that the UI is the form itself, and when one wants to customize the license on that screen, after clicking on the link to do so, by-sa-4.0 is selected. The fix is probably to make that radio select list input, which is hidden by default, set to the preferences' default.
Change 191191 had a related patch set uploaded (by Gilles):
Respect preferences' default license when picking a license per file
Yes
This only happens when uploading multiple files, single file upload works as expected.
I have also seen this happening with uploading a single file.
Also I must note that this issue did not happen with all uploads of multiple files or single files, but only happened with a part of the uploads.
If I now test the UploadWizard at the 'Release rights' page and click on 'Use a different license', CC0 is selected. However, yesterday I noticed that while checking this, not CC0 was selected but CC-BY-SA-4.0.
Maybe the issue is situated elsewhere. I am not always using the same way to reach the upload wizard. When I start with uploading I usually use the link in the sidebar. But when I have uploaded my first group of files, at the end of the upload wizard there is a button 'Upload more files' which I then use.
I just made 2 test uploads, each with 2 files. With both sets I did almost exactly the same, but with only one difference: The first set was uploaded with clicking in the sidebar, the result was CC0 at the file pages. The second upload was with clicking on the button 'Upload more files' on the last upload wizard page of the first uploaded set: the result there was CC-BY-SA-4.0 (while it showed CC0 during in the upload wizard).
Thanks for the extra info, I'll test the "upload more files" scenario to see if there's more to fix than the code I've found so far.
Change 191191 merged by jenkins-bot:
Respect preferences' default license when picking a license per file