Page MenuHomePhabricator

refactor upload.rb: move it from the VE repo to a reusable module so that it would be possible to use it for other features
Closed, ResolvedPublic

Description

upload.rb uploads auto-translated screenshots to Commons after creating them. It is not unique to VisualEditor and can be used by other MediaWiki features. The screenshot capturing itself was already moved to a gem. The uploading functionality is distinct and should be in a different module, although I'm not sure where exactly: maybe a gem, maybe a part of the MediaWiki API gem, or maybe something else.

Tagging VisualEditor because it's in that repo now, and ContentTranslation because CX is one of the first possible targets for using this.

Event Timeline

Amire80 created this task.Feb 17 2015, 3:05 PM
Amire80 raised the priority of this task from to Needs Triage.
Amire80 updated the task description. (Show Details)
Amire80 added subscribers: Amire80, zeljkofilipin, Vikassy.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 17 2015, 3:05 PM
Elitre added a subscriber: Elitre.Feb 17 2015, 3:14 PM
Jdforrester-WMF triaged this task as Low priority.Feb 17 2015, 8:00 PM
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
Jdforrester-WMF set Security to None.
Amire80 claimed this task.Feb 19 2015, 10:25 AM

Change 191563 had a related patch set uploaded (by Amire80):
[BrowserTest] Move the screenshot uploading to a gem

https://gerrit.wikimedia.org/r/191563

Patch-For-Review

Change 191563 merged by jenkins-bot:
[BrowserTest] Move the screenshot uploading to a gem

https://gerrit.wikimedia.org/r/191563

Amire80 closed this task as Resolved.Feb 19 2015, 11:00 AM

Moved upload.rb to a gem: https://rubygems.org/gems/commons_upload .

The auto-translated screenshots capturing and uploading functionality should be easily reusable in other extensions now!

Thanks to @zeljkofilipin for the help!