...for performance reason. This is a blocker for production usage.
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Hygiene: Use one query to get all page images | mediawiki/extensions/Gather | master | +24 -2 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 191584 had a related patch set uploaded (by Florianschmidtwelzow):
Hygiene: Use one query to get all page images
Comment Actions
Patch seems good, but there is a method that does exactly that on PageImages but it is private... :( We should probably modify push to that extension to have the method public (i don't remember the exact name, it was something like getArticleIds)
Comment Actions
Result example:
"1": { "pageid": 1, "ns": 0, "title": "Alan Smithee" }, "20": { "pageid": 20, "ns": 0, "title": "Liste von Autoren/G" }, "80": { "pageid": 80, "ns": 0, "title": "Muhammad ibn Musa al-Chwarizmi" }, "214": { "pageid": 214, "ns": 0, "title": "Alfred Nobel", "pageimage": "AlfredNobel_adjusted.jpg" }
@MaxSem: would you be ok, if this function is public?
Comment Actions
if i understand @Jhernandez correct, he is fine with the change in Gather, can you take a look if we just reuse this part of code? :D Thanks!