Can't edit claim value once save clicked and got error
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

None

Authored By

	Addshore
	Feb 18 2015, 1:27 AM

Description

Procedure to reproduce:

Start creating a new claim on an item.
Use a URL property such as "official website"
Add an invalid url such as "www.thebicyclingguitarist.net"
Click save
Receive "Malformed URL: www.thebicyclingguitarist.net" error
Try to edit / fix the URL and realise you can't, because the text field is not editable anymore. You could just cancel and restart.

This also happens with the other data types.

Details

	Subject	Repo	Branch	Lines +/-
	Reenable widget after save failed	mediawiki/extensions/Wikibase	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: rEWBAe6eeb3899706: Reenable widget after save failed
rMEXT4c376048b0a9: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase…

Event Timeline

Addshore created this task.Feb 18 2015, 1:27 AM

Addshore raised the priority of this task from to Needs Triage.

Addshore updated the task description. (Show Details)

Addshore added a project: MediaWiki-extensions-WikibaseRepository.

Addshore added subscribers: Addshore, Lydia_Pintscher.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 18 2015, 1:27 AM

Lydia_Pintscher triaged this task as High priority.Feb 18 2015, 10:53 AM

Lydia_Pintscher added a project: Wikidata.

Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.

Lydia_Pintscher added subscribers: JanZerebecki, hoo, adrianheine, thiemowmde.

Lydia_Pintscher added a subscriber: Snaterlicious.

JanZerebecki updated the task description. (Show Details)Feb 18 2015, 2:29 PM

JanZerebecki set Security to None.

Sjoerddebruin subscribed.Jun 10 2015, 6:47 PM

Mbch331 subscribed.Jun 16 2015, 4:45 PM

Lydia_Pintscher renamed this task from Can't edit claim value once save clicked and got Malformed URL error to Can't edit claim value once save clicked and got error.Jun 22 2015, 8:56 AM

Lydia_Pintscher updated the task description. (Show Details)

Lydia_Pintscher merged a task: T103295: Wikidata snak value input field disabled after trying to save invalid data.

Lydia_Pintscher added a subscriber: WMDE-Fisch.

I think the relevant place in our code base is jquery.ui.EditableTemplatedWidget.js. In line 129 the stopEditing function calls this.disable(). I think this is the reason why the widget can not be edited any more after an error. The fix is possibly a single self.enable(); line.

Change 223791 had a related patch set uploaded (by Jonas Kress (WMDE)):
Reenable widget after save failed

https://gerrit.wikimedia.org/r/223791

gerritbot added a project: Patch-For-Review.Jul 9 2015, 2:47 PM

I fixed that one, but unfortunately property selector stays disabled. So if you chose the wrong selector and try to change it after running into a save error.....

Change 223791 merged by jenkins-bot:
Reenable widget after save failed

https://gerrit.wikimedia.org/r/223791

Diffusion mentioned this in rMEXT4c376048b0a9: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jul 13 2015, 3:24 PM

• Jonas mentioned this in rEWBAe6eeb3899706: Reenable widget after save failed.Jul 13 2015, 3:24 PM

Can this be closed then?

thiemowmde closed this task as Resolved.Jul 13 2015, 7:16 PM

thiemowmde claimed this task.

thiemowmde moved this task from Backlog to Done on the Wikidata-Sprint-2015-06-30 board.

• Jonas removed thiemowmde as the assignee of this task.Jul 13 2015, 7:17 PM

Lydia_Pintscher edited a custom field.Jul 13 2015, 7:34 PM

matej_suchanek removed a project: Patch-For-Review.Jul 14 2015, 5:37 AM

matej_suchanek removed a subscriber: gerritbot.