Page MenuHomePhabricator
Create Task
Maniphest T89819

Convert mediawiki.special.preferences to make use of mediawiki.confirmCloseWindow
Closed, ResolvedPublic
Actions

Description

After mediawiki.confirmCloseWindow module was created to avoid code duplication, we didn't remove the code duplication that already existed inside mediawiki.special.preferences.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+10 -34Preferences: Use mediawiki.confirmCloseWindow module
Customize query in gerrit

Related Objects

Event Timeline

TheDJ created this task.Feb 18 2015, 11:51 AM
TheDJ raised the priority of this task from to Needs Triage.
TheDJ updated the task description. (Show Details)
TheDJ added projects: JavaScript, MediaWiki-Special-pages.
TheDJ added a subscriber: TheDJ.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 18 2015, 11:51 AM
gerritbot added a subscriber: gerritbot.Feb 18 2015, 10:58 PM

Change 191490 had a related patch set uploaded (by TheDJ):
Preferences: Use mediawiki.confirmCloseWindow module

https://gerrit.wikimedia.org/r/191490

Patch-For-Review

gerritbot added a comment.Feb 20 2015, 10:59 AM

Change 191490 merged by jenkins-bot:
Preferences: Use mediawiki.confirmCloseWindow module

https://gerrit.wikimedia.org/r/191490

hoo mentioned this in rMW2550a3c691b2: Preferences: Use mediawiki.confirmCloseWindow module.Feb 20 2015, 10:59 AM
TheDJ closed this task as Resolved.Feb 20 2015, 2:42 PM
TheDJ claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL