mediawiki.feedback is used in VisualEditor for submitting comments/suggestions. The dialog for submitting feedback currently uses jQuery UI, which makes it look nonstandard relative to the rest of the UI, non-responsive, and may also be implicated in causing "Escape" to trigger a full exit if no changes have been made.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Refactoring mw.Feedback to work with OOUI elements | mediawiki/core | master | +504 -299 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T29852 Wikimedia wikis need better issue reporting system | |||
| Open | None | T89880 Improvements to mediawiki.feedback (tracking) | |||
| Resolved | Mooeypoo | T89878 mediawiki.feedback should use OOjs UI dialog |
Event Timeline
Comment Actions
This doesn't have anything to do with extending or modifying the OOjs UI library, just using it.
Comment Actions
@TheDJ tagged T89815 with OOUI, and it doesn't involve extending or modifying the OOjs UI library either.
And why is this tagged VisualEditor, if mediawiki.feedback lives in core (and BTW is also used in UploadWizard)?
Comment Actions
You removed OOUI from T89815, but it is still not clear to me why this is tagged VisualEditor.
Comment Actions
Because the tool is most noticeably used in VisualEditor, hence the UI clash being more urgent than general backlog.
Comment Actions
Change 192749 had a related patch set uploaded (by Mooeypoo):
[wip] Refactoring mw.Feedback to work with OOUI elements
Comment Actions
Change 192749 merged by jenkins-bot:
Refactoring mw.Feedback to work with OOUI elements