Maniphest T89905

Remove use of ve.indexOf
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Jdforrester-WMF

Authored By

	Krinkle
	Feb 18 2015, 11:10 PM

Tags

Referenced Files

None

Subscribers

Jdforrester-WMF

Description

I noticed we still have ve.indexOf.

Since we depend on ES5 now. There's no reason have this indirection through a jQuery callback. As the native implementation is an Array instance method (unlike static Array.isArray/jQuery.isArray), there is an unavoidable function and call-binding overhead from using jQuery.inArray.

We've done the same for ve.bind. Let's do this for ve.indexOf as well.

Event Timeline

Krinkle created this task.Feb 18 2015, 11:10 PM

Krinkle raised the priority of this task from to Needs Triage.

Krinkle updated the task description. (Show Details)

Krinkle added projects: Technical-Debt, VisualEditor, Performance Issue.

Krinkle subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 18 2015, 11:10 PM

Krinkle updated the task description. (Show Details)Feb 18 2015, 11:11 PM

Krinkle set Security to None.

Jdforrester-WMF triaged this task as Low priority.Feb 21 2015, 8:12 PM

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.

Krinkle removed a project: Performance Issue.May 18 2015, 5:54 PM

Yay. https://gerrit.wikimedia.org/r/195582

ve.utils: Remove ve.indexOf in favour of Array#indexOf
Change-Id: I019338a812c0f61ac8fcdc693ff1b4a1cb5089ad

And a search for "ve.indexOf" has only one match; the deprecated definition of ve.indexOf itself.

Done in Ib6aca26b.

Jdforrester-WMF closed this task as Resolved.Nov 19 2015, 2:51 AM

Jdforrester-WMF claimed this task.

Jdforrester-WMF added a project: WMF-deploy-2015-08-04_(1.26wmf17).

Jdforrester-WMF edited a custom field.