Page MenuHomePhabricator

Edit button in heading overlaps alias text
Closed, ResolvedPublic

Description

The edit button in the heading overlaps with the alias text.

if the edit button is supposed to be sticky, then should have some background to distinguish and overlay on top of the aliases. or maybe it is not supposed to be sticky like this?

Event Timeline

aude raised the priority of this task from to Needs Triage.
aude updated the task description. (Show Details)
aude added a subscriber: aude.
aude renamed this task from edit button in heading overlaps alias text to Edit button in heading overlaps alias text.Feb 19 2015, 4:28 PM

Change 192301 had a related patch set uploaded (by Aude):
Adjust edit buttons and h1 header css in entitytermsview

https://gerrit.wikimedia.org/r/192301

Patch-For-Review

Change 192459 had a related patch set uploaded (by Aude):
Fix overlap of edit button and aliases text

https://gerrit.wikimedia.org/r/192459

Patch-For-Review

Change 192459 abandoned by Aude:
Fix overlap of edit button and aliases text

Reason:
i have another (partial) solution and propose https://phabricator.wikimedia.org/T92390 also

https://gerrit.wikimedia.org/r/192459

Change 195951 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Add white background to overlapping edit buttons

https://gerrit.wikimedia.org/r/195951

In addition to Thiemo's change, I think the edit toolbar / links should not have auto width (for now) and be in alignment with the edit links in the statements section. This gives much more consistent and polished appearance imho:

This can be done by removing auto width (though the functionality can remain in sticknode, as it might be needed for other things or in the future with further redesign) and re-add some padding only for the label.

Change 196011 had a related patch set uploaded (by Aude):
Remove auto width from edit toolbar in entitytermsview

https://gerrit.wikimedia.org/r/196011

Change 195951 merged by jenkins-bot:
Add white background to overlapping edit buttons

https://gerrit.wikimedia.org/r/195951

I think the white background is satisfactory enough as a solution to this.

If we want to spend more time on my auto width patch and https://phabricator.wikimedia.org/T92390, that's fine though have a separate task for that.

aude moved this task from Review to Done on the § Wikidata-Sprint-2015-03-11 board.