Edit button in heading overlaps alias text
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aude
	Feb 19 2015, 2:55 PM

Description

The edit button in the heading overlaps with the alias text.

if the edit button is supposed to be sticky, then should have some background to distinguish and overlay on top of the aliases. or maybe it is not supposed to be sticky like this?

Details

	Subject	Repo	Branch	Lines +/-
	Add white background to overlapping edit buttons	mediawiki/extensions/Wikibase	master	+5 -0
	Fix overlap of edit button and aliases text	mediawiki/extensions/Wikibase	master	+5 -0

Customize query in gerrit

Revisions and Commits

rEWBA extension-Wikibase
	rEWBA0858781453be Adjust edit buttons and h1 header css in entitytermsview
	rEWBAa38f06cbbe37 Adjust edit buttons and h1 header css in entitytermsview

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Invalid	None	T75654 Redesign Wikidata header
Resolved	Lydia_Pintscher	T105335 description edit button overlaps with long descriptions
Resolved	aude	T89956 Edit button in heading overlaps alias text
		· · ·

Event Timeline

aude created this task.Feb 19 2015, 2:55 PM

aude raised the priority of this task from to Needs Triage.

aude updated the task description. (Show Details)

aude subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 19 2015, 2:55 PM

aude added a project: Wikidata.Feb 19 2015, 3:04 PM

aude set Security to None.

Lydia_Pintscher triaged this task as High priority.Feb 19 2015, 3:10 PM

Lydia_Pintscher added a parent task: T75654: Redesign Wikidata header.

Lydia_Pintscher added subscribers: Snaterlicious, thiemowmde, adrianheine.

aude renamed this task from edit button in heading overlaps alias text to Edit button in heading overlaps alias text.Feb 19 2015, 4:28 PM

Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Feb 19 2015, 4:53 PM

Change 192301 had a related patch set uploaded (by Aude):
Adjust edit buttons and h1 header css in entitytermsview

https://gerrit.wikimedia.org/r/192301

Patch-For-Review

Aklapper added a project: Patch-For-Review.Feb 23 2015, 5:18 PM

Change 192459 had a related patch set uploaded (by Aude):
Fix overlap of edit button and aliases text

https://gerrit.wikimedia.org/r/192459

Patch-For-Review

Tobi_WMDE_SW added a project: § Wikidata-Sprint-2015-02-25.Feb 25 2015, 12:26 PM

Tobi_WMDE_SW moved this task from Backlog to Review on the § Wikidata-Sprint-2015-02-25 board.

Tobi_WMDE_SW assigned this task to aude.Feb 25 2015, 2:58 PM

Tobi_WMDE_SW added a project: § Wikidata-Sprint-2015-03-11.Mar 11 2015, 12:47 PM

Tobi_WMDE_SW moved this task from Backlog to Review on the § Wikidata-Sprint-2015-03-11 board.Mar 11 2015, 12:52 PM

Change 192459 abandoned by Aude:
Fix overlap of edit button and aliases text

Reason:
i have another (partial) solution and propose https://phabricator.wikimedia.org/T92390 also

https://gerrit.wikimedia.org/r/192459

Change 195951 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Add white background to overlapping edit buttons

https://gerrit.wikimedia.org/r/195951

thiemowmde mentioned this in T92390: [Bug] entitytermsview edit toolbar should not stick to the header-row of the "other languages" box.Mar 11 2015, 5:09 PM

In addition to Thiemo's change, I think the edit toolbar / links should not have auto width (for now) and be in alignment with the edit links in the statements section. This gives much more consistent and polished appearance imho:

This can be done by removing auto width (though the functionality can remain in sticknode, as it might be needed for other things or in the future with further redesign) and re-add some padding only for the label.

Change 196011 had a related patch set uploaded (by Aude):
Remove auto width from edit toolbar in entitytermsview

https://gerrit.wikimedia.org/r/196011

Change 195951 merged by jenkins-bot:
Add white background to overlapping edit buttons

https://gerrit.wikimedia.org/r/195951

thiemowmde mentioned this in rEWBA83b92a4330cc: Add white background to overlapping edit buttons.Mar 12 2015, 11:51 AM

Diffusion mentioned this in rMEXT1a44017f820e: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Mar 12 2015, 11:51 AM

I think the white background is satisfactory enough as a solution to this.

If we want to spend more time on my auto width patch and https://phabricator.wikimedia.org/T92390, that's fine though have a separate task for that.

aude closed this task as Resolved.Mar 18 2015, 6:06 PM

aude moved this task from Review to Done on the § Wikidata-Sprint-2015-03-11 board.

thiemowmde added a parent task: T105335: description edit button overlaps with long descriptions.Jul 9 2015, 2:19 PM

matej_suchanek removed a project: Patch-For-Review.Jul 11 2015, 3:37 PM