Include lib and dist into OOjs UI's jsduck output directory so the documentation examples work
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	Feb 20 2015, 11:50 AM

Description

https://gerrit.wikimedia.org/r/#/c/190116/ didn't really make @example work.

It fulfilled jsduck's requirement of having an eg-iframe.html file, but the examples don't yet work.

https://doc.wikimedia.org/oojs-ui/master/#!/api/OO.ui.ButtonInputWidget

ReferenceError: OO is not defined

Location: https://doc.wikimedia.org/oojs-ui/master/
404 (Not Found) https://doc.wikimedia.org/oojs-ui/lib/oojs.jquery.js
404 (Not Found) https://doc.wikimedia.org/oojs-ui/dist/oojs-ui.js
404 (Not Found) https://doc.wikimedia.org/oojs-ui/dist/oojs-ui-apex.js
404 (Not Found) https://doc.wikimedia.org/oojs-ui/dist/oojs-ui-apex.css

It's stabbing in the dark by loading things from a parent directory that it thinks is the oojs-ui git root, but is actually an unrelated directory holding different versions of oojs-ui documentation. The docs/ published from Jenkins needs to be self-contained.

Details

	Subject	Repo	Branch	Lines +/-
	build: Include 'lib' and 'dist' in jsduck output	oojs/ui	master	+29 -5

Customize query in gerrit

Related Objects

Mentioned In: rGOJUbade83bfdfc3: build: Include 'lib' and 'dist' in jsduck output
rGOJU44f9401629bd: build: Use grunt-contrib-copy instead of custom 'copy' task

Event Timeline

Krinkle created this task.Feb 20 2015, 11:50 AM

Krinkle claimed this task.

Krinkle raised the priority of this task from to Needs Triage.

Krinkle updated the task description. (Show Details)

Krinkle added a project: OOUI.

Krinkle subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2015, 11:50 AM

Oops! It worked on my machine? :P

Jdforrester-WMF renamed this task from Include lib and dist into jsduck output directory to Include lib and dist into OOjs UI's jsduck output directory so the documentation examples work.Feb 20 2015, 6:23 PM

Jdforrester-WMF triaged this task as Medium priority.

Jdforrester-WMF added a project: Continuous-Integration-Infrastructure.

Jdforrester-WMF set Security to None.

Change 192034 had a related patch set uploaded (by Krinkle):
build: Include 'lib' and 'dist' in jsduck output

https://gerrit.wikimedia.org/r/192034

Patch-For-Review

Jdforrester-WMF closed this task as Resolved.Feb 21 2015, 12:42 AM

Jdforrester-WMF added projects: WMF-deploy-2015-02-25_(1.25wmf19), OOjs-UI-next-release.

Jdforrester-WMF subscribed.

Change 192034 merged by jenkins-bot:
build: Include 'lib' and 'dist' in jsduck output

https://gerrit.wikimedia.org/r/192034

Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.8.1); removed OOjs-UI-next-release.Feb 26 2015, 2:17 AM

Jdforrester-WMF added a project: WMF-deploy-2015-03-04_(1.25wmf20).

hashar moved this task from Untriaged to Done on the Continuous-Integration-Infrastructure board.Feb 28 2015, 2:17 PM

Krinkle mentioned this in rGOJU44f9401629bd: build: Use grunt-contrib-copy instead of custom 'copy' task.Mar 3 2015, 7:50 PM

Krinkle mentioned this in rGOJUbade83bfdfc3: build: Include 'lib' and 'dist' in jsduck output.

Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Mar 26 2015, 9:00 PM

Include lib and dist into OOjs UI's jsduck output directory so the documentation examples workClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Include lib and dist into OOjs UI's jsduck output directory so the documentation examples work
Closed, ResolvedPublic
Actions