LDAP based login is broken in pywikibot because lgdomain is not set
Closed, ResolvedPublic
Actions

Description

Couldn't figure out why core didn't work on my wiki with LDAP login. After some debugging I found out that lgdomain doesn't seem to be set anywhere at all. See https://www.mediawiki.org/w/api.php?action=help&modules=login|query+info

If I just hardcode login_request["lgdomain"] = "mydomain" in api.py, it magically works. The login logic should look in the family file if self.ldapDomain is set and if that's the case include it in the request. Compat doesn't have this problem.

Details

	Subject	Repo	Branch	Lines +/-
	Fix broken LDAP based login	pywikibot/core	master	+3 -0

Customize query in gerrit

Event Timeline

Multichill created this task.Feb 20 2015, 3:21 PM

Multichill raised the priority of this task from to High.

Multichill updated the task description. (Show Details)

Multichill added projects: Pywikibot, Pywikibot-login.py, Pywikibot-compat-to-core.

Multichill subscribed.

Restricted Application added subscribers: Aklapper, Unknown Object (MLST). · View Herald TranscriptFeb 20 2015, 3:21 PM

Can we set lgdomain even without LDAP login?

Dumindux claimed this task.Mar 4 2015, 6:47 AM

Dumindux removed Dumindux as the assignee of this task.

Dumindux set Security to None.

This is pretty good first task, as it needs to be backwards compatible with compat, so no bikeshedding on names, etc. and it should be two lines of code in core.

compat$ git grep ldapDomain
families/README-family.txt:        #self.ldapDomain = 'domain here'
family.py:        self.ldapDomain = ()
login.py:            if self.site.family.ldapDomain:
login.py:                predata['lgdomain'] = self.site.family.ldapDomain
login.py:            if self.site.family.ldapDomain:     # VistaPrint fix
login.py:                predata["wpDomain"] = self.site.family.ldapDomain

jayvdb added a project: good first task.May 30 2015, 5:05 PM

@Multichill, are you able to test patches for this?

darthbhyrava subscribed.Feb 29 2016, 2:47 AM

Hi, I am interested in working on this bug.
As far as I understand (from the discussions above) there needs to be a check on ldapDomain and lgdomain should be set accordingly, somewhere near line no. 3036 in
api.py
i.e. just after the initialisation.
I'm completely new to this so please correct me if I'm wrong somewhere and should I move ahead resolving this bug?

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptSep 25 2016, 5:16 PM

why in API.py? Can't it be done in the login.py like how it was done in compact?

The modification to api.py outlined here resolved the issue for me:

https://www.linkedin.com/pulse/how-correct-pywikibot-ldap-authentication-error-armando-trinchillo

LDAP authentication worked until I added a second domain to the authentication options in my LocalSettings.php. I have not had an opportunity to revert the change and test, but I wanted to mention it just in case it helps reproduce the issue.

I will mentor this in Google-Code-In-2016