Page MenuHomePhabricator
Create Task
Maniphest T90199

When a link is added, the card should be updated and the added link should be selected
Closed, ResolvedPublic
Actions

Assigned To
Etonkovidova
Authored By
Amire80
Feb 20 2015, 4:26 PM
Tags
Referenced Files
F24669271: Screen Shot 2018-08-07 at 4.31.14 PM.png
Aug 7 2018, 11:40 PM
F24669314: Screen Shot 2018-08-07 at 4.32.53 PM.png
Aug 7 2018, 11:40 PM
F24669361: Screen Shot 2018-08-07 at 4.36.09 PM.png
Aug 7 2018, 11:40 PM
F24669095: Screen Shot 2018-08-07 at 4.20.40 PM.png
Aug 7 2018, 11:40 PM
F24669369: Screen Shot 2018-08-07 at 4.36.28 PM.png
Aug 7 2018, 11:40 PM
F24669248: Screen Shot 2018-08-07 at 4.28.54 PM.png
Aug 7 2018, 11:40 PM
F24669066: Screen Shot 2018-08-07 at 4.18.17 PM.png
Aug 7 2018, 11:40 PM
F24669073: Screen Shot 2018-08-07 at 4.18.28 PM.png
Aug 7 2018, 11:40 PM
View All 10 Files
Subscribers
Aklapper
Amire80
Etonkovidova
Nikerabbit
Pginer-WMF

Description

The link card should be updated when adding links of any color: redlinks, regular blue links, or turning missing grey links into red.

This is especially problematic when marking a link as red link: the card remains visible but it is not updated, providing still the option to mark as redlink despite being already a red link. You need to select the link again for the options to be updated.

For regular links, it seems that after a link is added the caret position is reset, and the link card disappears. It would be better if it got updated and remained visible.

Related Objects
Search...

Event Timeline

Amire80 raised the priority of this task from to Needs Triage.Feb 20 2015, 4:26 PM
Amire80 added projects: Language-Team, ContentTranslation.
Amire80 subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2015, 4:26 PM
Arrbee updated the task description. (Show Details)Feb 24 2015, 6:18 AM
Arrbee set Security to None.
Amire80 triaged this task as Medium priority.Feb 26 2015, 8:28 AM
Arrbee added a parent task: T76449: [Epic] ContentTranslation - Translation view.Mar 2 2015, 10:10 AM
Amire80 closed this task as Resolved.Jul 3 2015, 3:55 PM
Amire80 claimed this task.
Amire80 added a subscriber: Pginer-WMF.

This is not exactly what is happening now, but the current behavior with adaptable links seems OK to me. @Pginer-WMF, please reopen if there's anything else to address.

Pginer-WMF reopened this task as Open.Jul 3 2015, 4:45 PM

This is specially problematic when when marking a link as red link: the card remains visible but it is not updated, providing still the option to mark as redlink despite being already a red link. You need to select the link again for the options to be updated.

For regular links, it seems that after a link is added the caret position is reseted, and the link card disappears. It would be better if it got updated and remain visible.

Nikerabbit subscribed.Jul 3 2015, 6:14 PM

Dupe T104339?

Amire80 moved this task from Needs Triage to CX6 on the ContentTranslation board.Jul 5 2015, 7:58 PM
Amire80 edited projects, added ContentTranslation-Release6; removed Language-Team.Jul 6 2015, 11:05 AM
Amire80 moved this task from Backlog to Links on the ContentTranslation-Release6 board.Jul 6 2015, 11:33 AM
Amire80 removed Amire80 as the assignee of this task.Jul 11 2015, 9:43 AM
Amire80 added a comment.Sep 9 2015, 1:21 PM
In T90199#1425469, @Nikerabbit wrote:

Dupe T104339?

Sounds like it, and T104339 has a clear description (and a picture). @Pginer-WMF should confirm.

Pginer-WMF added a comment.Sep 9 2015, 3:11 PM

This card is more general. The link card should be updated when adding links of any color: redlinks, regular blue links, or turning missing grey links into red. I don't mind which card is merged into which one, but let's make sure the issue is fixed for all kinds of links (and reflect that into the card).

Amire80 moved this task from CX6 to CX7 on the ContentTranslation board.Oct 2 2015, 3:03 PM
Amire80 updated the task description. (Show Details)Oct 13 2015, 9:54 AM
Amire80 edited projects, added Essential-Work; removed ContentTranslation-Release6.
Amire80 added a parent task: T76455: [Epic] ContentTranslation - Link Adaptation.
Amire80 moved this task from CX7 to Bugs on the ContentTranslation board.Oct 18 2015, 12:21 PM
Arrbee moved this task from Bugs to Check & Move on the ContentTranslation board.Jun 5 2018, 12:17 PM
Arrbee assigned this task to Etonkovidova.Jun 6 2018, 3:49 PM
Etonkovidova added a comment.EditedAug 7 2018, 11:40 PM
In T90199#1620822, @Pginer-WMF wrote:

This card is more general. The link card should be updated when adding links of any color: redlinks, regular blue links, or turning missing grey links into red.

That's how currently links are working in cx1. I checked T104339: "Mark as missing" lacks feedback - the issue seems to be gone, so @Nikerabbit may check and marked the task as Resolved.
The following example (en:Schläfli to català) illustrates how the links are handled in cx1 which in my opinion is correct.

  • two types of links - blue and grey - are present in the translated text:

Screen Shot 2018-08-07 at 4.15.08 PM.png (108×899 px, 34 KB)

  • clicking on word for which an article exists will display:
    Screen Shot 2018-08-07 at 4.18.17 PM.png (299×930 px, 56 KB)
  • click on 'Mark as missing' - and the link becomes red and the link card link also becomes red:

Screen Shot 2018-08-07 at 4.18.28 PM.png (322×928 px, 57 KB)

  • clicking on a grey link displays the same behavior:

Screen Shot 2018-08-07 at 4.20.40 PM.png (283×908 px, 50 KB)

Screen Shot 2018-08-07 at 4.21.00 PM.png (288×912 px, 52 KB)

@Pginer-WMF Please review how cx2 handles the links:

  • the same translation - the same set of links:

Screen Shot 2018-08-07 at 4.28.54 PM.png (138×901 px, 40 KB)

  • selecting a word and double-clicking on it display suggestions only to the first letter(there was a bug filed about it). It seems that the link can be inserted only with 'Insert link' button:

Screen Shot 2018-08-07 at 4.31.14 PM.png (227×875 px, 37 KB)

  • I selected from drop-down suggestions and clicked on 'Add link' - the word becomes blue indicating that the existing link was created:

Screen Shot 2018-08-07 at 4.32.53 PM.png (230×865 px, 37 KB)

  • a grey link:

Screen Shot 2018-08-07 at 4.36.09 PM.png (205×877 px, 42 KB)

  • clicked on 'Mark as missing':

Screen Shot 2018-08-07 at 4.36.28 PM.png (185×872 px, 43 KB)

Etonkovidova removed Etonkovidova as the assignee of this task.Aug 7 2018, 11:41 PM
Etonkovidova subscribed.
Etonkovidova mentioned this in T104339: "Mark as missing" lacks feedback.Aug 8 2018, 11:07 PM
Etonkovidova closed this task as Resolved.Aug 8 2018, 11:10 PM
Etonkovidova claimed this task.

The issue(s) reported in the ticket are resolved in cx2. I filed another task T201570: CX2: Click on 'Edit' for links - page jumps to the top - it was found when I was verifying this ticket.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL