Page MenuHomePhabricator

Remove browser specific code in ULS for IE6, IE7 and IE8
Open, LowPublic

Description

JavaScript is disabled, so if there is any specific code, it should be removed.

Event Timeline

Amire80 raised the priority of this task from to Needs Triage.Feb 20 2015, 4:32 PM
Amire80 added a subscriber: Amire80.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2015, 4:32 PM
Arrbee updated the task description. (Show Details)Feb 24 2015, 6:37 AM
Arrbee set Security to None.
Amire80 renamed this task from Remove browser specific code for ULS for IE6, IE7 to Remove browser specific code for ULS for IE6, IE7 from ULS.Mar 12 2015, 9:12 AM
Amire80 triaged this task as Low priority.
Amire80 updated the task description. (Show Details)
Amire80 added a project: Technical-Debt.

Is that an good first task task for a contributor? If so, how to find such code?
Grep'ing for "IE" and "Internet Explorer"? Something else? Feel free to add good first task when there's clear instructions.

./lib/jquery.uls/css/jquery.uls.grid.css: For IE7/8 compatibility block-grid items need to be
./lib/jquery.uls/css/jquery.uls.grid.css: that IE7/8 do not support :nth-child.
./lib/jquery.webfonts.js:			// IE
./lib/jquery.ime/jquery.ime.js:			// IE
./lib/jquery.ime/jquery.ime.js:	 * Helper function to get an IE TextRange object for an element
./lib/jquery.ime/jquery.ime.js:	function rangeForElementIE( element ) {
./lib/jquery.ime/jquery.ime.js:			// IE9+ and all other browsers
./lib/jquery.ime/jquery.ime.js:			// IE8 and lower
./lib/jquery.ime/jquery.ime.js:			selection = rangeForElementIE(element);
./lib/jquery.ime/jquery.ime.js:			// IE doesn't count \n when computing the offset, so we won't either

I expect most of the effort is actually finding such code rather than fixing it. Grepping is a start but might not find everything. This is especially the case when there is a better way to do things but we used a different way because we wanted to support IE.

Looking at your grep there probably isn't that many or any obvious things to remove.

Krinkle renamed this task from Remove browser specific code for ULS for IE6, IE7 from ULS to Remove browser specific code in ULS for IE6, IE7 and IE8.Feb 25 2016, 6:54 PM