Page MenuHomePhabricator

Rework utfnormal Makefile into a PHP script
Closed, ResolvedPublic

Description

The Makefile copied from the old libs dir is broken by the new directory structure.

It does basically three things:

  1. run the tests
  1. run the benchmark
  1. rebuild data array files

(and fetch the unicode data files for the above)

  1. and 2) can be easily replaced with 'composer test' etc with appropriate config?
  1. can be replaced with a nice PHP script that fetches the files and runs the build scripts, which would be less shell-dependent and may work better for third-party users.

(IIRC the makefile was a little fragile and sometimes had to be tweaked to run on both OSX and Linux etc)

Details

Related Changes in Gerrit:

Event Timeline

brooke raised the priority of this task from to Needs Triage.
brooke updated the task description. (Show Details)
brooke subscribed.

The benchmark was moved to scripts/benchmark.php and rebuilding the files is scripts/generate.php. I think the only functionality we're missing is automatically downloading new unicode data files?

I think we should integrate benchmark into "composer test" and have a separate "composer rebuild" to rebuild the data tables. It would take an additional --fetch command to redownload the data files.

Change 192619 had a related patch set uploaded (by Legoktm):
Make it easier to run scripts, remove Makefile

https://gerrit.wikimedia.org/r/192619

Patch-For-Review

Change 192619 merged by Brion VIBBER:
Make it easier to run scripts, remove Makefile

https://gerrit.wikimedia.org/r/192619