Page MenuHomePhabricator

TMH abuses SetupAfterCache hook, should use $wgExtensionFunctions instead
Closed, ResolvedPublic

Description

legoktm> SetupAfterCache should only be used for initialization that actually needs to run right after $wgMemc stuff is created...everything else should use $wgExtensionFunctions

This block is mostly there to make sure that MwEmbedSupport stuff is properly loaded before TMH really starts going.

Event Timeline

TheDJ raised the priority of this task from to Needs Triage.
TheDJ updated the task description. (Show Details)
TheDJ added a subscriber: TheDJ.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 198486 had a related patch set uploaded (by TheDJ):
Use wgExtensionFunctions instead of SetupAfterCache hook

https://gerrit.wikimedia.org/r/198486

MarkTraceur claimed this task.
MarkTraceur added a subscriber: MarkTraceur.

Looks fine to me now, thanks!

Change 198486 merged by jenkins-bot:
Use wgExtensionFunctions instead of SetupAfterCache hook

https://gerrit.wikimedia.org/r/198486

Change 270127 had a related patch set uploaded (by TheDJ):
Use CanonicalNamespaces hook instead of SetupAfterCache

https://gerrit.wikimedia.org/r/270127

Change 270127 merged by jenkins-bot:
Use CanonicalNamespaces hook instead of SetupAfterCache

https://gerrit.wikimedia.org/r/270127