At https://phabricator.wikimedia.org/p/MZMcBride/ it currently reads "MediaWiki Userpage: Unknown". I find this a bit tacky. Can't it just output nothing instead? Or even better would be if Phabricator allowed me to set the user page... can't find an option for that.
Description
Description
Details
Details
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| Enhance Phorge event rendering | toolforge-repos/wikibugs2!17 | bd808 | work/bd808/irc-formatting | main |
Revisions and Commits
Revisions and Commits
| Unknown Object (Diffusion Commit) |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • mmodell | T541 Polish "MediaWiki Userpage" field in user profiles | |||
| Declined | • mmodell | T903 Do not show "MediaWiki Userpage" on Phabricator profile if value is "Unknown" |
Event Timeline
Comment Actions
Note that this is also the case for LDAP:
LDAP User Unknown
However, if a user doesn't introduce an IRC handle, the IRC field is not shown.
I find more elegant the option to show fields only when there is data for them. Otherwise it is better not to show them at all.
@mmodell, what is you opinion for the Wikimedia SUL extension?
Comment Actions
I don't think this would be very difficult though I'm not sure it's really beneficial either.
Comment Actions
So I tried to implement this and it turns out to not be straight-forward.
The shouldAppearInPropertyView method gets called before the user object is set. So this makes it impossible to look up the account details and return a conditional response based on whether the field has a value.
So without some sort of hacky patch to phabricator I don't think this change is possible. It's simply not worth the amount of effort it's going to take for such a superficial benefit.