Page MenuHomePhabricator

Difference alignment wrong when new paragraph added above a changed paragraph or when a paragraph is split into two
Closed, DuplicatePublic

Description

When viewing the difference (diff) of my contribution recently, I noticed that if I add a new paragraph above (before) an existing paragraph, and also change some text in the existing paragraph, the side-by-side diff is incorrectly shown. The new paragraph on right is aligned with the existing paragraph on the left, and their texts are compared, while the modified existing paragraph on the right is shown as a new paragraph. This is very wrong and needs to be fixed!

https://en.wikipedia.org/w/index.php?title=The_Interview_%282014_film%29&diff=prev&oldid=648145143

There are also other problems like when a paragraph is split into two, the second paragraph on the right is treated as a new one, rather than being compared to the text of the first paragraph on the left.

https://en.wikipedia.org/w/index.php?title=The_Interview_%282014_film%29&diff=prev&oldid=648153747

Event Timeline

Agent007bond raised the priority of this task from to Needs Triage.
Agent007bond updated the task description. (Show Details)
Agent007bond added a subscriber: Agent007bond.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2015, 10:04 PM
Agent007bond renamed this task from Difference alignment wrong when new paragraph added above a changed paragraph to Difference alignment wrong when new paragraph added above a changed paragraph or when a paragraph is split into two.Feb 21 2015, 10:07 PM
Agent007bond set Security to None.

Hi @Agent007bond. Thanks for taking the time to report this!
This particular problem has already been reported into our bug tracking system as T7072, but please feel free to report any further issues you find. Further handling of the reported issue happens in T7072.

Also see T26617 about sentence level.

Thanks! I couldn't find that duplicate due to the different wording. At least this will lead to that for anyone in the future :)