Page MenuHomePhabricator

[Bug] Incorrect links for external changes in client watchlist atom and rss feeds
Open, MediumPublic

Description

Incorrect links (to client instead of repo diff) are included in client watchlist atom and rss feeds for external changes.

In atom:

<entry>
<id>
http://wikidata-client/index.php?title=Magnesium&diff=10011
</id>
<title>Magnesium</title>
<link rel="alternate" type="text/html" href="http://wikidata-client/index.php?title=Magnesium&diff=10011"/>
<updated>2015-02-22T14:27:24Z</updated>
<summary type="html">(Admin)</summary>
<author>
<name>Admin</name>
</author>
</entry>

RSS:

<title>Magnesium</title>
<link>
http://wikidata-client/index.php?title=Magnesium&diff=10011
</link>
<guid isPermaLink="false">
http://wikidata-client/index.php?title=Magnesium&diff=10011
</guid>
<description>(Admin)</description>
<pubDate>Sun, 22 Feb 2015 14:27:24 GMT</pubDate>
<dc:creator>Admin</dc:creator>
</item>

ApiFeedWatchlist currently works as a wrapper around the ApiQuery watchlist module, doing a FauxRequest. It does not get the proper information for building links (might need rc_source to know it's a wikibase repo change, plus a correct diff id and title on the repo).

then, ApiFeedWatchlist builds the diff link using $title->getFullURL(). We might then be able to use interwiki/foreign title to construct the links in the feed, or some other solution.

Event Timeline

aude created this task.Feb 22 2015, 3:32 PM
aude raised the priority of this task from to Needs Triage.
aude updated the task description. (Show Details)
aude added a subscriber: aude.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2015, 3:32 PM
Lydia_Pintscher triaged this task as Medium priority.Feb 22 2015, 4:47 PM
Lydia_Pintscher set Security to None.
aude renamed this task from Incorrect links for external changes in client watchlist atom and rss feeds to [Bug] Incorrect links for external changes in client watchlist atom and rss feeds.Sep 10 2015, 11:05 AM