Page MenuHomePhabricator

Incorrect links and empty diff in client recentchanges rss and atom feeds
Closed, DuplicatePublic

Description

ApiFeedRecentChanges works as a wrapper around SpecialRecentChanges, obtaining change entries from there. As such, user preference for "Show Wikidata edits in recent changes" carries over to the recent changes feed.

When these entries *are* included, the link is wrong and the summary / diff is empty.

Once the rows are obtained from SpecialRecentChanges, the feed entries are created in ChangesFeed::buildItems and FeedUtils::formatDiff builds the summary.

Not exactly sure how we would want to handle entries from WikibaseRepo.

<entry>
<id>
http://wikidata-client/index.php?title=Magnesium&diff=10011&oldid=10011
</id>
<title>Magnesium</title>
<link rel="alternate" type="text/html" href="http://wikidata-client/index.php?title=Magnesium&diff=10011&oldid=10011"/>
<updated>2015-02-22T14:27:24Z</updated>
<summary type="html">
<p></p> <table class='diff diff-contentalign-left'> <tr style='vertical-align: top;'> <td colspan='1' style="background-color: white; color:black; text-align: center;">← Older revision</td> <td colspan='1' style="background-color: white; color:black; text-align: center;">Revision as of 14:27, 22 February 2015</td> </tr><tr><td colspan='2' style='text-align: center;'><div class="mw-diff-empty">(No difference)</div> </td></tr></table>
</summary>
<author>
<name>Admin</name>
</author>
</entry>

Event Timeline

aude created this task.Feb 22 2015, 3:42 PM
aude raised the priority of this task from to Needs Triage.
aude updated the task description. (Show Details)
aude added subscribers: aude, Aklapper.
Lydia_Pintscher triaged this task as Medium priority.Feb 22 2015, 4:47 PM
Lydia_Pintscher set Security to None.