Change 192706 had a related patch set uploaded (by Mpaa):
reflink.py: check if botMayEdit()

https://gerrit.wikimedia.org/r/192706

@jayvdb: Should something like BotMayEditBot be a subclass of Bot?

Hmm shouldn't save throw an exception if bots aren't allowed to edit?

Yes, save should throw an exception and always check whether the edit is allowed. I thought this is already implemented. I guess in compat this works in that way.

This bug is invalid. There is no documented {{nobots}} with allow or deny arguments. See the documentation for the templates on de or en wiki.

Change 192706 abandoned by Mpaa:
page.py: fix Page.botMayEdit()

Reason:
Bug T90422 is not applicable.

https://gerrit.wikimedia.org/r/192706

Are you sure? {{nobots}} on enwp redirects to bots, which allows the parameter. And why is this bug invalid? A bot shouldn't edit the page if there is a nobots template. It doesn't matter that exactly that bot is denied. Shouldn't it deny all bots anyway.

The Russian {{nobots}} btw does not redirect to bots.

Change 192706 restored by Mpaa:
page.py: fix Page.botMayEdit()

Reason:
Keep the test part.

https://gerrit.wikimedia.org/r/192706

@darthbhyrava what is to claim here?

I dont understand why this is invalid. I think @XZise is correct in his earlier comment T90422#1070932

This is a redirect to the description page. {{nobots}} and {{bots}} doesn't have the same behaviour.

I disagree. Bot's {{bots}}/{{nobots}} behaviour must reflect the common use of enabling/disabling bot edits. We should not introduce a new set of templates and parameters. Others would use other templates the bot does not understand. Vice versa is the right way. Users should read the documentation before they assume any bot directives.

In T90422#2093544, @Xqt wrote:

I disagree. Bot's {{bots}}/{{nobots}} behaviour must reflect the common use of enabling/disabling bot edits. We should not introduce a new set of templates and parameters.

I agree. nobots with parameter deny should be considered unrecognised syntax/invalid/etc.

Others would use other templates the bot does not understand. Vice versa is the right way. Users should read the documentation before they assume any bot directives.

I dont understand your argument here. Templates that we dont understand are ignored.

However Pywikibot explicitly supports and implements nobots and bots. The users expect Pywikibot to do this. If Pywikibot encounters some unrecognised syntax in nobots and bots, Pywikibot must err on the side of caution; i.e. avoid editing the page. A very loud warning would be appropriate. We could also create a script that finds any pages using nobots/bots with unrecognised syntax and the script could fix the page syntax.

We could also create a script that finds any pages using nobots/bots with unrecognised syntax and the script could fix the page syntax.

We should start at ar-wiki. They try to localize that template. I am strongly against localizing bot directives. They must be a common template for all sites and projects. pywikibot is not the one and only bot framework. Ok we should have any exception handling when the template does not follow the syntax.

In addition pywikibot does not follow optout parameter for notification messages.

These improvements aren't reflinks related only.

In T90422#2206201, @Xqt wrote:

We could also create a script that finds any pages using nobots/bots with unrecognised syntax and the script could fix the page syntax.

We should start at ar-wiki. They try to localize that template. I am strongly against localizing bot directives. They must be a common template for all sites and projects. pywikibot is not the one and only bot framework. Ok we should have any exception handling when the template does not follow the syntax.

In addition pywikibot does not follow optout parameter for notification messages.

These improvements aren't reflinks related only.

The template title on arwiki is localized to make it easier for users to add the template in the edit window. (It is hard to write LTR text mixed with RTL text in the edit window in a wiki whose content language is RTL such as arwiki.) Also, the local naming policy states that page titles should always be in Arabic (except for a very few cases). The arwiki bots template has no parameters.

@Meno25: Anyway I guess it's a bad idea because most bot's doesn't recognize. A better solution might be adding these templates to the tool bar for the local wiki.

In T90422#2267593, @Xqt wrote:

@Meno25: Anyway I guess it's a bad idea because most bot's doesn't recognize. A better solution might be adding these templates to the tool bar for the local wiki.

Since you are a Pywikibot developer, then you know better. I will move the template to its standard English name and cite your message as reason.

In T90422#2267687, @Meno25 wrote:

In T90422#2267593, @Xqt wrote:

@Meno25: Anyway I guess it's a bad idea because most bot's doesn't recognize. A better solution might be adding these templates to the tool bar for the local wiki.

Since you are a Pywikibot developer, then you know better. I will move the template to its standard English name and cite your message as reason.

Moved.