I tried to run the qunit tests from a labs vagrant instance, with the roles commons and wikidata enabled.
This failed until I added
$wgResourceLoaderMaxQueryLength = 4096;
to the LocalSettings.php with the error
414 Request-URI Too Large (nginx/1.5.0).
Should there be some sane default for $wgResourceLoaderMaxQueryLength instead of the current unlimited?
When running the qunit job in jenkins for wikibase.git it also fails without that setting.
Change 193130 had a related patch set uploaded (by JanZerebecki):
Change default of $wgResourceLoaderMaxQueryLength to 2000
This change (Ic416def846f361425c46f7b) in general seems fine. However I'd like to see further evidence that the QUnit jenkins job is indeed failing because of this. And as a general practice it seems to me that requesting so many modules in one request means one of two things:
It is definitely too naive for ResourceLoader not have a limit by default. However I argue this limit should never be reached. If this limit is reached, we're talking about failure mode / error handling / graceful degradation, not normal modus operandi.
I suppose the test is slightly different in that it requests everything at once in a way production never would. A quick check to verify that is the case would be nice.
We may want to add a logged check to mediawiki.js asserting the request is shorter. It'd be tolerated in tests (until we find a better way to deal with that).
Test run without that setting: https://integration.wikimedia.org/ci/job/mwext-Wikibase-qunit-experiment/9/consoleFull
And with that setting: https://integration.wikimedia.org/ci/job/mwext-Wikibase-qunit-experiment/10/consoleFull
The test run without that setting failed even though it shows as green because --force was added as an argument to qunit.
I'd like to have a discussion about this resp. ask you some questions regarding that. I don't know where the right place for that would be, though.
It is definitely too naive for ResourceLoader not have a limit by default. However I argue this limit should never be reached. If this limit is reached, we're talking about failure mode / error handling / graceful degradation, not normal modus operandi.
Dropping to some failure mode seems quite arbitrary to me. I can't see any inherit reason for this to not just work as it does. Logging a warning is something different, that might make sense.
For Wikidata this has been resolved for now by https://gerrit.wikimedia.org/r/196241.
Change 193130 merged by jenkins-bot:
Change default of $wgResourceLoaderMaxQueryLength to 2000
Change 200937 had a related patch set uploaded (by JanZerebecki):
Do not set $wgResourceLoaderMaxQueryLength for tests
Change 200937 merged by jenkins-bot:
Do not set $wgResourceLoaderMaxQueryLength for tests