[Bug] Deprecated configuration (phpunit) setting "strict" used
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	aude
	Feb 23 2015, 5:09 PM

Description

The "strict" option which is in mediawiki's suite.xml is deprecated in phpunit 4.5.0. It appears to be replaced with some more "granular options".

https://github.com/sebastianbergmann/phpunit-documentation/issues/282

https://github.com/sebastianbergmann/phpunit/issues/914

I suppose as long as we support older versions of phpunit, then we should keep strict for now? at some point we should decide which of these other options we want and add them.

Event Timeline

aude created this task.Feb 23 2015, 5:09 PM

aude raised the priority of this task from to Medium.

aude updated the task description. (Show Details)

aude added a project: MediaWiki-Core-Tests.

aude subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2015, 5:09 PM

aude renamed this task from Deprecated configuration (phpunit) setting "strict" used to [Bug] Deprecated configuration (phpunit) setting "strict" used.Sep 10 2015, 11:06 AM

aude set Security to None.

Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jul 7 2017, 5:16 AM

It should be easy for us to replace strict=true with the more granular options that replaced it (https://github.com/sebastianbergmann/phpunit-documentation/issues/282#issuecomment-305139418). I'll mentor this for GCI.

You'll need to update tests/phpunit/suite.xml to no longer use the deprecated strict=true setting, and instead use the equivalent options.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJan 9 2018, 8:35 PM

divadsn subscribed.Jan 22 2018, 8:43 AM

Aklapper added a project: Google-Code-in-2018.Aug 30 2018, 10:24 PM

https://codein.withgoogle.com/tasks/6659291873280000/

Aklapper removed a project: Google-Code-in-2017.Oct 15 2018, 7:12 PM

Liuxinyu970226 subscribed.Oct 21 2018, 2:13 AM

Isn't this task completed with https://phabricator.wikimedia.org/T99982?

@LukBukkit

https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/dbe3499113feaf3192fc4efcedfccda13b151767%5E%21/#F2

Appears so. I think this should be removed from the GCI website then as I accidentally claimed this without doing my due diligence

Aklapper closed this task as a duplicate of T99982: Upgrade PHPUnit to 4.0+.May 7 2020, 12:50 PM

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptMay 7 2020, 12:50 PM

TerraCodes unsubscribed.May 10 2020, 12:19 AM

[Bug] Deprecated configuration (phpunit) setting "strict" usedClosed, DuplicatePublicActions

Description

Event Timeline

[Bug] Deprecated configuration (phpunit) setting "strict" used
Closed, DuplicatePublic
Actions