Page MenuHomePhabricator

[Bug] Deprecated configuration (phpunit) setting "strict" used
Closed, DuplicatePublic

Description

The "strict" option which is in mediawiki's suite.xml is deprecated in phpunit 4.5.0. It appears to be replaced with some more "granular options".

https://github.com/sebastianbergmann/phpunit-documentation/issues/282

https://github.com/sebastianbergmann/phpunit/issues/914

I suppose as long as we support older versions of phpunit, then we should keep strict for now? at some point we should decide which of these other options we want and add them.

Event Timeline

aude raised the priority of this task from to Medium.
aude updated the task description. (Show Details)
aude added a project: MediaWiki-Core-Tests.
aude added a subscriber: aude.
aude renamed this task from Deprecated configuration (phpunit) setting "strict" used to [Bug] Deprecated configuration (phpunit) setting "strict" used.Sep 10 2015, 11:06 AM
aude set Security to None.
Legoktm added a subscriber: Legoktm.

It should be easy for us to replace strict=true with the more granular options that replaced it (https://github.com/sebastianbergmann/phpunit-documentation/issues/282#issuecomment-305139418). I'll mentor this for GCI.

You'll need to update tests/phpunit/suite.xml to no longer use the deprecated strict=true setting, and instead use the equivalent options.

@LukBukkit

https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/dbe3499113feaf3192fc4efcedfccda13b151767%5E%21/#F2

Appears so. I think this should be removed from the GCI website then as I accidentally claimed this without doing my due diligence