Page MenuHomePhabricator

Values from mwyaml backend don't override values from ops/pupppet yaml files in hieradata/labs
Closed, ResolvedPublic

Description

Hiera values from Hiera:<projectname> pages on wikitech don't seem to be taken into account by puppet at all. It is reading only the bits from ops/puppet.

This has been going on since Ifa5c79bc10f1147518fbf352d75c9fcd3019bd72

Event Timeline

yuvipanda raised the priority of this task from to Needs Triage.
yuvipanda updated the task description. (Show Details)
yuvipanda added a project: Cloud-Services.
yuvipanda added subscribers: yuvipanda, Joe.

Right, I think what happens is if your project already has hiera files in ops/puppet and then you try to override them on wikitech, *that* doesn't show up.

yuvipanda renamed this task from mwyaml backend isn't tried at all to Values from mwyaml backend don't override values from ops/pupppet yaml files in hieradata/labs.Feb 26 2015, 12:00 PM
yuvipanda added projects: acl*sre-team, Puppet.
yuvipanda set Security to None.

Uhm, this is the case because you specifically asked the values in puppet/hieradata to be authoritative :)

We can change that of course.

oh, right. I guess that's a miscommunication somewhere.

I'd definitely want wikitech values to override ops/puppet values.

yuvipanda triaged this task as Medium priority.Feb 26 2015, 12:09 PM

Since Ifa5c79bc10f1147518fbf352d75c9fcd3019bd72 I don't think mwyaml will read from Hiera:<project> since the regex specified in mwyaml_backend.rb no longer matches the labs.hiera.yaml:

https://github.com/wikimedia/operations-puppet/blob/production/modules/wmflib/lib/hiera/backend/mwyaml_backend.rb#L17
https://github.com/wikimedia/operations-puppet/blob/production/modules/puppetmaster/files/labs.hiera.yaml#L12
https://regex101.com/r/eM9aP1/1

I created a patch in gerrit that should fix the problem: https://gerrit.wikimedia.org/r/#/c/193165/

Change 193165 had a related patch set uploaded (by Greg Grossmeier):
Change regex to match labs hiera config

https://gerrit.wikimedia.org/r/193165

Change 193165 merged by Andrew Bogott:
Remove regex from labs hiera config

https://gerrit.wikimedia.org/r/193165

This seems to be fixed now? \o/