Page MenuHomePhabricator

Get PageTriage browser tests running on MediaWiki-Vagrant
Closed, DeclinedPublic

Description

The PageTriage browser tests are not set up to run in MediaWiki-Vagrant.

There is no browser_tests => true (https://git.wikimedia.org/blob/mediawiki%2Fvagrant.git/66b6677e009475530d289a8624568a2c587c50c4/puppet%2Fmodules%2Frole%2Fmanifests%2Fpagetriage.pp), but adding that was not sufficient to get it work for me.

Firefox started up, but never made it to any page. See https://gerrit.wikimedia.org/r/#/c/186949/ .

Event Timeline

EBernhardson subscribed.

@dduvall: do you know what the problem is here?

hashar subscribed.

@Mattflaschen I guess this is still a problem. Can you please enhance the task detail with step to reproduce and what fails?

This is not related to browser tests, but mediawiki vagrant.

Change 227637 had a related patch set uploaded (by Mattflaschen):
WIP: Run PageTriage browser tests

https://gerrit.wikimedia.org/r/227637

  1. Checkout MediaWiki-Vagrant change https://gerrit.wikimedia.org/r/227637 (which adds browser_tests => true).
  2. vagrant enable-role pagetriage
  3. vagrant reload --provision
  4. vagrant ssh
  5. cd /vagrant/mediawiki/extensions/PageTriage/tests/browser/
  6. bundle install
  7. bundle exec cucumber

It still opens Firefox, does nothing, then fails:

#
# This file is subject to the license terms in the LICENSE file found in the
# qa-browsertests top-level directory and at
# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/LICENSE. No part of
# qa-browsertests, including this file, may be copied, modified, propagated, or
# distributed except according to the terms contained in the LICENSE file.
#
# Copyright 2012-2014 by the Mediawiki developers. See the CREDITS file in the
# qa-browsertests top-level directory and at
# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/CREDITS
#
@chrome @en.wikipedia.beta.wmflabs.org @firefox @internet_explorer_8 @internet_explorer_9 @internet_explorer_10 @phantomjs @test2.wikipedia.org
Feature: PageTriage

  @internet_explorer_6 @internet_explorer_7
  Scenario: Check that NewPagesFeed has correct controls for anonymous user # features/page_triage.feature:16
 unable to obtain stable firefox connection in 60 seconds (127.0.0.1:7055) (Selenium::WebDriver::Error::WebDriverError)
 /var/lib/gems/2.0.0/gems/selenium-webdriver-2.41.0/lib/selenium/webdriver/firefox/launcher.rb:79:in `connect_until_stable'
 /var/lib/gems/2.0.0/gems/selenium-webdriver-2.41.0/lib/selenium/webdriver/firefox/launcher.rb:37:in `block in launch'
 /var/lib/gems/2.0.0/gems/selenium-webdriver-2.41.0/lib/selenium/webdriver/firefox/socket_lock.rb:20:in `locked'
 /var/lib/gems/2.0.0/gems/selenium-webdriver-2.41.0/lib/selenium/webdriver/firefox/launcher.rb:32:in `launch'
 /var/lib/gems/2.0.0/gems/selenium-webdriver-2.41.0/lib/selenium/webdriver/firefox/bridge.rb:24:in `initialize'
 /var/lib/gems/2.0.0/gems/selenium-webdriver-2.41.0/lib/selenium/webdriver/common/driver.rb:31:in `new'
 /var/lib/gems/2.0.0/gems/selenium-webdriver-2.41.0/lib/selenium/webdriver/common/driver.rb:31:in `for'
 /var/lib/gems/2.0.0/gems/selenium-webdriver-2.41.0/lib/selenium/webdriver.rb:67:in `for'
 /var/lib/gems/2.0.0/gems/watir-webdriver-0.6.9/lib/watir-webdriver/browser.rb:46:in `initialize'
 /var/lib/gems/2.0.0/gems/mediawiki_selenium-0.2.20/lib/mediawiki_selenium/support/env.rb:70:in `new'
 /var/lib/gems/2.0.0/gems/mediawiki_selenium-0.2.20/lib/mediawiki_selenium/support/env.rb:70:in `local_browser'
 /var/lib/gems/2.0.0/gems/mediawiki_selenium-0.2.20/lib/mediawiki_selenium/support/env.rb:26:in `browser'
 /var/lib/gems/2.0.0/gems/mediawiki_selenium-0.2.20/lib/mediawiki_selenium/support/hooks.rb:29:in `Before'
    Given I am at the NewPagesFeed page                                     # features/step_definitions/page_triage_steps.rb:12
    Then I should see a Learn more link                                     # features/step_definitions/page_triage_steps.rb:20
    And I should see a Leave feedback link                                  # features/step_definitions/page_triage_steps.rb:39
    And I should see a status icon for a new article                        # features/step_definitions/page_triage_steps.rb:43
    And I should not see a Review button                                    # features/step_definitions/page_triage_steps.rb:47
      undefined method `close' for nil:NilClass (NoMethodError)
      /var/lib/gems/2.0.0/gems/mediawiki_selenium-0.2.20/lib/mediawiki_selenium/support/hooks.rb:50:in `After'

Change 227637 abandoned by Mattflaschen:
WIP: Run PageTriage browser tests

Reason:
This was not enough to get it working. If someone wants to get this working, they can just redo that line or unabandon this.

https://gerrit.wikimedia.org/r/227637

zeljkofilipin lowered the priority of this task from Medium to Low.

Unlikely to ever be resolved because of T139740: Port Selenium tests from Ruby to Node.js.