Page MenuHomePhabricator
Create Task
Maniphest T90494

Popups doesn't show for anchored links since 1.25wmf18
Closed, ResolvedPublic
Actions

Description

Previous title: Popups doesn't show up at all on mediawiki.org
Popups doesn't show up at all for me on phase/group0 wikis, mw.popups.selectPopupElements() is empty on e.g. mediawiki.org/wiki/Flow
For sure this was caused by https://gerrit.wikimedia.org/r/146477
Failure at:

this.href === mw.config.get( 'wgServer' ) + mw.util.getUrl( this.title )

e.g.

https://www.mediawiki.org/wiki/Flow#Release_and_features_FAQ === //www.mediawiki.org/wiki/Flow

Rollback that change, verify on beta that it's working again and backport to current branches?

Update: A simple hotfix I have written got deployed and applied to 1.25wmf18 before it got out to group1 and all wikis to prevent rendering the complete feature unuseable.
But due the simplicity of the fix, there's now still the regression that popups doesn't show up for anchored links.

Event Timeline

Se4598 created this task.Feb 23 2015, 9:47 PM
Se4598 raised the priority of this task from to Unbreak Now!.
Se4598 updated the task description. (Show Details)
Se4598 added projects: Page-Previews, Regression.
Se4598 added subscribers: Se4598, greg, • Prtksxna.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2015, 9:47 PM
Se4598 added a project: WMF-Server-Backports.Feb 23 2015, 9:49 PM
Se4598 updated the task description. (Show Details)Feb 23 2015, 9:52 PM
Se4598 set Security to None.
Se4598 added a comment.Feb 23 2015, 10:29 PM

I have created the following patch https://gerrit.wikimedia.org/r/192465 as alternative to revert, but must be reviewed if this really fixes that problem.

JanZerebecki subscribed.Feb 24 2015, 3:08 PM
PeterBowman subscribed.Feb 24 2015, 3:10 PM
Se4598 renamed this task from Popups doesn't show up at all on mediawiki.org to Popups doesn't show for anchored links since 1.25wmf18.Feb 24 2015, 9:52 PM
Se4598 assigned this task to • Prtksxna.
Se4598 lowered the priority of this task from Unbreak Now! to High.
Se4598 updated the task description. (Show Details)
Se4598 edited projects, added Patch-For-Review; removed WMF-Server-Backports.
Se4598 added a subscriber: • mmodell.
Se4598 added a comment.Feb 24 2015, 9:58 PM

A simple hotfix I have written got deployed and applied to 1.25wmf18 before it got out to group1 and all wikis to prevent rendering the complete feature unuseable (not showing up anywhere).
But due the simplicity of the fix, there's now the regression that popups doesn't show up for anchored links. This regression will hit all wikipedias tomorrow with group2 deployment.

The follow-up patchset to find the right solution, clean up the fix and solve the anchor issue is https://gerrit.wikimedia.org/r/192568.

@Prtksxna: I have assigned this to you, so you can asses the situation and agree upon the next things to do here.

Aklapper added a comment.Mar 3 2015, 2:01 PM
In T90494#1063972, @Se4598 wrote:

@Prtksxna: I have assigned this to you, so you can asses the situation and agree upon the next things to do here.

Prtksxna: Any thoughts?

• Prtksxna closed this task as Resolved.Mar 5 2015, 4:46 AM
• Prtksxna reassigned this task from • Prtksxna to Se4598.

https://gerrit.wikimedia.org/r/#/c/192568/ has been merged.

Ricordisamoa removed a project: Patch-For-Review.Mar 5 2015, 1:59 PM
Ricordisamoa subscribed.
• Prtksxna moved this task from Backlog to Done on the Page-Previews board.Mar 12 2015, 10:25 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL